Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

CHE-10167 Improving for the CheTaskProvider #3

Merged
merged 2 commits into from
Aug 13, 2018
Merged

CHE-10167 Improving for the CheTaskProvider #3

merged 2 commits into from
Aug 13, 2018

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 9, 2018

Improving for the CheTaskProvider. Add a preselected machine name from the command attribute 'machineName'.

Related issue: eclipse-che/che#10167

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link
Contributor

@sunix sunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me.
However in general for bugs, I would be describing the problem, how to reproduce it in a separate issue or in the PR description. and have only 1 PR per bug.

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 13, 2018

@sunix ok I will do that

@olexii4 olexii4 merged commit 7748a8b into master Aug 13, 2018
@olexii4 olexii4 deleted the CHE-10167 branch August 13, 2018 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants