Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs how to build Che server in Che workspace #14181

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Add docs how to build Che server in Che workspace #14181

merged 1 commit into from
Aug 16, 2019

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Aug 9, 2019 •
edited
Loading

Covers Che server section of #14126

Also changes the entrypoint.sh of Che server in order to respect CHE_HOME environment variable.

Additional thanks for @sleshchenko for help in this issue while dealing with Openshift cluster config.

@mmorhun mmorhun self-assigned this Aug 9, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@mmorhun mmorhun added the area/doc Issues related to documentation label Aug 9, 2019
@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 9, 2019
sleshchenko
sleshchenko reviewed Aug 9, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
sunix
sunix reviewed Aug 9, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mmorhun mmorhun requested a review from benoitf as a code owner August 13, 2019 14:00
@eclipse-che eclipse-che deleted a comment from che-bot Aug 13, 2019
AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 14, 2019
View reviewed changes
devfile.yaml Outdated Show resolved Hide resolved
@mmorhun mmorhun force-pushed the che-14126-wsmaster branch 2 times, most recently from 1af2dd0 to 7c25935 Compare August 14, 2019 12:23
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

AndrienkoAleksandr
AndrienkoAleksandr approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build commands.

skabashnyuk
skabashnyuk reviewed Aug 14, 2019
View reviewed changes
devfile.yaml
image: 'eclipse/che-dev:nightly'
alias: che-server-dev
mountSources: true
memoryLimit: 5Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need 5GI here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just didn't touch the value...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3Gi should be enough

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3Gi should be enough

I'm not sure but it looks realistic after removing wsagent code from Che repo,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested - it isn't. Maybe we should play with build command more.

skabashnyuk
skabashnyuk reviewed Aug 14, 2019
View reviewed changes
devfile.yaml Outdated Show resolved Hide resolved
AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 14, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@AndrienkoAleksandr
Copy link
Contributor

Tested also starts che from che-server-runtime. Works fine. I hope in some day we will automate this staff with help of simple task. Nice work @mmorhun

@skabashnyuk
Copy link
Contributor

@mmorhun to be able to answer https://github.com/eclipse/che/pull/14181/files#r313891484 or #14181 (comment) first of all we need to know - do we want to use this flow on che.openshift.io or not?

@mmorhun
Copy link
Contributor Author

mmorhun commented Aug 15, 2019

@skabashnyuk this PR mostly about documenting the flow. I think memory optimization is out of PR's scope.

@dmytro-ndp
Copy link
Contributor

@mmorhun: FYI: Happy path tests failed that time because PR didn't have latest changes of from master.

@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

sleshchenko
sleshchenko reviewed Aug 15, 2019
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mmorhun mmorhun force-pushed the che-14126-wsmaster branch 3 times, most recently from a569651 to 7a37d62 Compare August 16, 2019 09:23
@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14181
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

sleshchenko
sleshchenko approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Please take a look my inline comments that I believe would do che-in-che development more comfortable.

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14181
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

vitaliy-guliy
vitaliy-guliy approved these changes Aug 16, 2019
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
devfile.yaml
image: 'eclipse/che-dev:nightly'
alias: che-server-dev
mountSources: true
memoryLimit: 5Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3Gi should be enough

@mmorhun
Add docs how to build Che server in Che workspace
e91ca1b 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14181

@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14181
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mmorhun mmorhun merged commit ef11a78 into master Aug 16, 2019
@mmorhun mmorhun deleted the che-14126-wsmaster branch August 16, 2019 13:43
@mmorhun mmorhun mentioned this pull request Aug 16, 2019
Closed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 16, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunix sunix sunix left review comments

@skabashnyuk skabashnyuk skabashnyuk left review comments

@sleshchenko sleshchenko sleshchenko approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@evidolob evidolob evidolob approved these changes

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@mmorhun mmorhun

Labels
area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
9 participants
@mmorhun @che-bot @AndrienkoAleksandr @skabashnyuk @dmytro-ndp @sunix @evidolob @vitaliy-guliy @sleshchenko