-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs how to build Che server in Che workspace #14181
Conversation
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
a02a948
to
9ffbd91
Compare
1af2dd0
to
7c25935
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested build commands.
image: 'eclipse/che-dev:nightly' | ||
alias: che-server-dev | ||
mountSources: true | ||
memoryLimit: 5Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need 5GI here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just didn't touch the value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3Gi should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3Gi should be enough
I'm not sure but it looks realistic after removing wsagent code from Che repo,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested - it isn't. Maybe we should play with build command more.
Tested also starts che from che-server-runtime. Works fine. I hope in some day we will automate this staff with help of simple task. Nice work @mmorhun |
@mmorhun to be able to answer https://github.com/eclipse/che/pull/14181/files#r313891484 or #14181 (comment) first of all we need to know - do we want to use this flow on che.openshift.io or not? |
@skabashnyuk this PR mostly about documenting the flow. I think memory optimization is out of PR's scope. |
@mmorhun: FYI: Happy path tests failed that time because PR didn't have latest changes of from master. |
0c7b89c
to
6d9bf11
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
a569651
to
7a37d62
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Please take a look my inline comments that I believe would do che-in-che development more comfortable.
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
7a37d62
to
3a2c0b9
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
3a2c0b9
to
694ab4b
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
image: 'eclipse/che-dev:nightly' | ||
alias: che-server-dev | ||
mountSources: true | ||
memoryLimit: 5Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3Gi should be enough
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
694ab4b
to
e91ca1b
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Covers Che server section of #14126
Also changes the
entrypoint.sh
of Che server in order to respectCHE_HOME
environment variable.Additional thanks for @sleshchenko for help in this issue while dealing with Openshift cluster config.