CHE-3774 Add Eclipse Vert.x stack to default assembly #3843
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Thank you @sbryzak for this PR! That's great to have a vertX stack. I'm wondering if we could also add the Dockerfile to https://github.com/eclipse/che-dockerfiles and double check with @dharmit if registry.centos.org/dharmit/vertx is the definitive repository or if we want to move it to something like registry.centos.org/che-stacks/vertx.
|
Thanks @sbryzak, that's really nice to have a vert.x stack. I would like to suggest two things to associate to this PR: wdyt @sbryzak ? |
slemeur
added
the
kind/enhancement
|
PR added to release note. |
|
@slemeur The following example may be used, what is the best/proper way to include this in Che? |
|
This pull request has been updated with the definitive repository registry.centos.org/che-stacks/vertx. It should be fine to merge it now. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1811/ |
| }], | ||
| "source": { | ||
| "type": "image", | ||
| "origin": "registry.centos.org/che-stacks/vertx" |
There was a problem hiding this comment.
@TylerJewell does it require an update of https://github.com/eclipse/che/blob/master/dockerfiles/cli/version/5.2.0/images-stacks
There was a problem hiding this comment.
I don't know what's in the provided image. However, the later versions the better for Vert.x. These JDK and Maven versions are the lower bounds, any more up to date version would be fine.
There was a problem hiding this comment.
I don't know what's in the provided image.
@cescoffier: you can find the Dockerfile and other files for the image here.
There was a problem hiding this comment.
Thanks, @dharmit. So it's Maven 3.3 (the one we used).
Note for me: don't forget to update the docker file after Vert.x releases.
| } | ||
| }, | ||
| "recipe": { | ||
| "location": "registry.centos.org/dharmit/vertx", |
There was a problem hiding this comment.
@sbryzak should we replace this with registry.centos.org/che-stacks/vertx as well?
There was a problem hiding this comment.
Oops, I missed that one - updated now.
benoitf
added
status/code-review
Signed-off-by: Shane Bryzak <sbryzak@redhat.com>
|
@TylerJewell we added vert.x image in the CLI image-stacks lists for version 5.3.0 and nightly. Is it good for you? |
| @@ -20,3 +20,4 @@ eclipse/ubuntu_jdk8 | |||
| eclipse/ubuntu_jre | |||
| eclipse/ubuntu_python | |||
| eclipse/ubuntu_wildfly8 | |||
| registry.centos.org/che-stacks/vertx | |||
|
@l0rd adding newline at end of file in dockerfiles/cli/version/5.3.0/images-stacks and I think you can merge |
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
|
@benoitf Thanks! |
|
Please remember to add the correct milestone when merging PRs - it makes it easier for PM to track for changelog and release notes. |
|
@bmicklea ok will do that |
JamesDrummond
removed
the
status/code-review
Signed-off-by: Shane Bryzak <sbryzak@redhat.com>
Signed-off-by: Shane Bryzak sbryzak@redhat.com
This pull request adds the Eclipse Vert.x stack to the default Che assembly.
What issues does this PR fix or reference?
CHE-3774
Changelog
Adds the Eclipse Vert.x stack to the default Che assembly.
Release note
We've added a new stack to for the Eclipse Vert.x project. This is a very popular toolkit for building reactive applications on the JVM. You can now build vert.x applications by simply creating a workspace from the vert.x stack - no configuration necessary!