Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on dashboard possibility to stop workspace while it is being started. #4246

Merged
merged 4 commits into from
Mar 1, 2017

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Feb 28, 2017

What does this PR do?

Add on dashboard possibility to stop workspace while it is being started.

What issues does this PR fix or reference?

codenvy/codenvy#1687
#3918
#3571
#3743
#4243

Changelog

  • Add on dashboard possibility to stop workspace while it is being started.
  • Improve machine runtime popups for dashboard
  • hide recipe location if it isn't url
  • Fixed sorting rules for recent workspaces

Release Notes

  • Add on dashboard possibility to stop workspace while it is being started.
  • Fixed sorting rules for recent workspaces

Docs PR

N/A

@codenvy-ci
Copy link

@olexii4
Copy link
Contributor Author

olexii4 commented Feb 28, 2017

Dashboard tests passed

@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 28, 2017
@slemeur
Copy link
Contributor

slemeur commented Feb 28, 2017

I don't understand why you have those mockup in this PR. does not seem to be related @olexii4 . Could you update with a gif please.

@olexii4
Copy link
Contributor Author

olexii4 commented Feb 28, 2017

I have add several little improvement/fixes to this PR:

1. improve machine runtime popups for dashboard

We have old one popup -
selection_004
I have improved it -
selection_001

2.hide recipe location link if it isn't url

We have old one -
selection_005

I have improved it. And now we have two variant(in case with url and other cases) -
selection_002
selection_003

3.fix sorting rule for recent workspaces
I have fixed a typo in one row and add a test for target controller.

@slemeur slemeur changed the title While workspaces are being started, they can be cancelled from the dashboard. Add on dashboard possibility to stop workspace while it is being started. Feb 28, 2017
@codenvy-ci
Copy link

@ashumilova ashumilova added this to the 5.4.0 milestone Mar 1, 2017
Oleksii Orel added 4 commits March 1, 2017 09:56
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
@olexii4 olexii4 merged commit 0d84dfb into master Mar 1, 2017
@olexii4 olexii4 deleted the CHE-3743 branch March 1, 2017 08:23
@JamesDrummond JamesDrummond mentioned this pull request Mar 8, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Add on dashboard possibility to stop workspace while it is being started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants