Send request with activity on ws-agent in a separate thread #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuznyetsov
force-pushed
the
che-9126
branch
2 times, most recently
from
29adcbd
to
ac422c0
Compare
benoitf
added
status/code-review
sleshchenko
reviewed
May 16, 2018
| } catch (Exception e) { | ||
| LOG.error("Cannot notify master about workspace " + wsId + " activity", e); | ||
| } | ||
| new Thread( |
There was a problem hiding this comment.
Should not be this thread daemon?
| } catch (Exception e) { | ||
| LOG.error("Cannot notify master about workspace " + wsId + " activity", e); | ||
| } | ||
| new Thread( |
There was a problem hiding this comment.
We need new Thread only when onActivity method is called but not when scheduleActivityNotification. Then maybe it would be better to have two methods: notifyActivity and notifyActivityAsync?
sleshchenko
approved these changes
May 16, 2018
|
@mkuznyetsov could you update |
|
ok |
skabashnyuk
reviewed
May 16, 2018
| */ | ||
| public void onActivity() { | ||
| long currentTime = System.currentTimeMillis(); | ||
| if (currentTime < (lastUpdateTime + threshold)) { | ||
| activeDuringThreshold.set(true); | ||
| } else { | ||
| notifyActivity(); | ||
| Thread activityRequestThread = new Thread(this::notifyActivity); | ||
| activityRequestThread.setDaemon(true); |
There was a problem hiding this comment.
give some meaningful name to this thread.
|
ci-test |
|
ci-test build report: |
skabashnyuk
approved these changes
May 17, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On WS-Agent, sending requests will be performed in separate threads, to prevent blocking the tomcat thread if request takes too long to complete.
What issues does this PR fix or reference?
#9126
Release Notes
Docs PR