Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fable_schema_string::interpolate fails when NAME variable is set #222

Closed
cassava opened this issue Mar 20, 2024 · 1 comment
Closed

Test fable_schema_string::interpolate fails when NAME variable is set #222

cassava opened this issue Mar 20, 2024 · 1 comment
Assignees
@cassava
Labels
bug Something isn't working c-fable Domain is the fable library
Milestone
0.23.0

Comments

@cassava
Copy link
Contributor

cassava commented Mar 20, 2024

image

It would appear that when NAME is set in the environment, the one set in the the fable environment does not take priority.

  • Is this behavior as intended? Then the test needs to be fixed.
  • If not, then we should fix it.
@cassava cassava self-assigned this Mar 20, 2024
@cassava cassava added bug Something isn't working c-fable Domain is the fable library labels Mar 20, 2024
@cassava cassava modified the milestones: 0.22.0, 0.23.0 Mar 20, 2024
cassava added a commit that referenced this issue Apr 9, 2024
@cassava
fable: Fix failing unit-test when NAME defined in environment
6bfee25 
It turned out to not be a problem with Environment as a problem
with the test and/or documentation.

Resolves issue #222.
cassava added a commit that referenced this issue Apr 22, 2024
@cassava
fable: Fix failing unit-test when NAME defined in environment
e715841 
It turned out to not be a problem with Environment as a problem
with the test and/or documentation.

Resolves issue #222.
cassava added a commit that referenced this issue Apr 22, 2024
@cassava
fable: Fix failing unit-test when NAME defined in environment
1b874bb 
It turned out to not be a problem with Environment as a problem
with the test and/or documentation.

Resolves issue #222.
@cassava
Copy link
Contributor Author

cassava commented Apr 22, 2024

Fixed on master.

@cassava cassava closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cassava cassava

Labels
bug Something isn't working c-fable Domain is the fable library
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
1 participant
@cassava