Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar cloud 2020 03 06 #2897

Merged
merged 15 commits into from
Aug 27, 2020
Merged

Conversation

lorthirk
Copy link

This PR fixes some issues (more than 500) on SonarCloud.

The most notable change here is the removal of the Type Parameter in KapuaQuery

Related Issue
No related issues

@lorthirk lorthirk added the Enhancement This PR/Issue improves an part of Kapua label Mar 17, 2020
@riccardomodanese riccardomodanese self-requested a review March 17, 2020 13:49
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #2897 into develop will increase coverage by 0.21%.
The diff coverage is 61.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2897      +/-   ##
=============================================
+ Coverage      57.79%   58.01%   +0.21%     
- Complexity      2596     2601       +5     
=============================================
  Files           1061     1069       +8     
  Lines          22874    22858      -16     
  Branches        2028     2023       -5     
=============================================
+ Hits           13221    13260      +39     
+ Misses          8710     8657      -53     
+ Partials         943      941       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/eclipse/kapua/broker/BrokerDomain.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...apua/broker/core/KapuaBrokerApplicationPlugin.java 57.14% <0.00%> (ø) 0.00 <0.00> (ø)
...apua/broker/core/KapuaBrokerJAXBContextLoader.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...e/kapua/broker/core/KapuaBrokerSecurityPlugin.java 71.42% <0.00%> (ø) 0.00 <0.00> (ø)
.../kapua/broker/core/converter/ConverterMetrics.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...pse/kapua/broker/core/listener/CamelConstants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/kapua/broker/core/listener/DataStoreMetrics.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...r/DeviceManagementRegistryNotificationMetrics.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ore/plugin/CachingConnectorDescriptorProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...oker/core/plugin/ConnectorDescriptorProviders.java 52.38% <0.00%> (ø) 0.00 <0.00> (ø)
... and 155 more

@lorthirk lorthirk force-pushed the fix-sonarCloud_2020_03_06 branch 4 times, most recently from 6fea97e to c3a8a50 Compare March 18, 2020 12:17
console/module/about/pom.xml Outdated Show resolved Hide resolved
console/core/pom.xml Outdated Show resolved Hide resolved
console/module/api/pom.xml Outdated Show resolved Hide resolved
console/module/data/pom.xml Outdated Show resolved Hide resolved
console/module/job/pom.xml Outdated Show resolved Hide resolved
@lorthirk lorthirk marked this pull request as draft April 28, 2020 10:10
@lorthirk lorthirk force-pushed the fix-sonarCloud_2020_03_06 branch 2 times, most recently from 3efcdb4 to a8c7544 Compare August 10, 2020 14:11
@LeoNerdoG
Copy link
Contributor

Hey @lorthirk, just a heads up: I have noticed that the headers are not updated to current year (2020). Because this is a stall PR i suggest to update the header year right before the merge, to avoid changing them multiple times in case the PR is prolonged into 2021.

@lorthirk
Copy link
Author

This PR is going to be merged in a few days, if not hours. I will try to update all the headers for the modified files if I find a quick way to do that.

@lorthirk lorthirk marked this pull request as ready for review August 25, 2020 12:35
Claudio Mezzasalma added 15 commits August 26, 2020 16:01
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the fix-sonarCloud_2020_03_06 branch from a8c7544 to c57bbc4 Compare August 26, 2020 14:05
@Coduz Coduz removed the Stale PR This PR has been sitting for a while. Needs to be checked before merging. label Aug 27, 2020
@Coduz Coduz merged commit 4c5abe4 into eclipse:develop Aug 27, 2020
@lorthirk lorthirk deleted the fix-sonarCloud_2020_03_06 branch October 19, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants