-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disabling datastore feature parameter #2963
Conversation
@lorthirk should we add a similar feature in the console and rest api also? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that <!-- BEGIN DATASTORE PERSISTENCE -->
and <!-- END DATASTORE PERSISTENCE -->
comments have now special semantics. Are we sure we want to do this? I suspect that someone could not understand this by just looking at the file. Maybe we should at least document this somewhere?
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
94140a8
to
27f595d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2963 +/- ##
=============================================
- Coverage 56.19% 56.11% -0.09%
- Complexity 2591 2594 +3
=============================================
Files 1061 1062 +1
Lines 23002 23042 +40
Branches 2064 2064
=============================================
+ Hits 12926 12930 +4
- Misses 9123 9140 +17
- Partials 953 972 +19 |
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
7e9ba8f
to
a96050b
Compare
Signed-off-by: riccardomodanese riccardo.modanese@eurotech.com
Added a feature to disable completely the datastore feature from the broker.
The idea is to allow Kapua to start and run without any exception in a deploy without any datastore.
This is controlled by an environment variable:
Related Issue
none
Description of the solution adopted
none
Screenshots
none
Any side note on the changes made
In this PR there's also some updates to the code originally merged with #2947. Specifically:
isAvailableService()
has been renamed toisServiceEnabled()
isAvailableProperty()
has been renamed toisPropertyEnabled()
isServiceEnabled()
has been moved fromAbstractKapuaConfigurableService
toAbstractKapuaService
KapuaServiceDisabledException
is thrown instead of silently returnnull