Enabling property to disable the OpenID Connect logout #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
This was referenced Jun 5, 2020
Coduz
approved these changes
Jun 10, 2020
LeoNerdoG
reviewed
Jun 10, 2020
console/core/src/main/java/org/eclipse/kapua/app/console/core/client/KapuaCloudConsole.java
Show resolved
Hide resolved
LeoNerdoG
reviewed
Jun 10, 2020
...ole/core/src/main/java/org/eclipse/kapua/app/console/core/server/GwtSettingsServiceImpl.java
Show resolved
Hide resolved
console/core/src/main/java/org/eclipse/kapua/app/console/core/client/NorthView.java
Show resolved
Hide resolved
...e/api/src/main/java/org/eclipse/kapua/app/console/module/api/setting/ConsoleSettingKeys.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #2996 +/- ##
=============================================
- Coverage 56.94% 51.68% -5.27%
+ Complexity 2598 2566 -32
=============================================
Files 1062 1062
Lines 22978 22978
Branches 2043 2043
=============================================
- Hits 13085 11876 -1209
- Misses 8928 10183 +1255
+ Partials 965 919 -46 |
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
Coduz
approved these changes
Jun 10, 2020
LeoNerdoG
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a property to disable the OpenID Connect logout.
Related Issue
N/A
Description of the solution adopted
The OpenID Connect logout can be disabled by setting the
console.sso.openid.logout.enabledproperty tofalse. This property is alwaystrueby default.If the OpenID logout is disabled, the user is allowed to login again into the Kapua Console without the need to provide any credentials.
Screenshots
N/A
Any side note on the changes made
This feature is implemented directly inside the
getSsoLogoutUrimethod of theGwtSettingsServiceImplclass. If the property isfalse, an empty string (URL) will be returned to the console on the browser side, and the call to the logout endpoint won't be performed. This simple approach has been preferred to the use of a dedicated callback, in order to avoid having too many nested callbacks.