Add Scope ID to isServiceEnabled() and isPropertyEnabled() #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3000 +/- ##
=============================================
+ Coverage 56.94% 57.74% +0.79%
- Complexity 2598 2605 +7
=============================================
Files 1062 1062
Lines 22978 22978
Branches 2043 2043
=============================================
+ Hits 13085 13268 +183
+ Misses 8928 8759 -169
+ Partials 965 951 -14
|
LeoNerdoG
reviewed
Jun 16, 2020
| @@ -99,7 +99,7 @@ public ChannelInfoRegistryServiceImpl() throws ClientUnavailableException { | |||
| @Override | |||
| public ChannelInfo find(KapuaId scopeId, StorableId id) | |||
| throws KapuaException { | |||
| if (!isServiceEnabled()) { | |||
| if (!isServiceEnabled(scopeId)) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -99,7 +99,7 @@ public ClientInfoRegistryServiceImpl() throws ClientUnavailableException { | |||
| @Override | |||
| public ClientInfo find(KapuaId scopeId, StorableId id) | |||
| throws KapuaException { | |||
| if (!isServiceEnabled()) { | |||
| if (!isServiceEnabled(scopeId)) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -229,7 +229,7 @@ protected void checkDataAccess(KapuaId scopeId, Actions action) | |||
| } | |||
|
|
|||
| @Override | |||
| protected boolean isServiceEnabled() { | |||
| protected boolean isServiceEnabled(KapuaId scopeId) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -101,7 +101,7 @@ public MetricInfoRegistryServiceImpl() throws ClientUnavailableException { | |||
| @Override | |||
| public MetricInfo find(KapuaId scopeId, StorableId id) | |||
| throws KapuaException { | |||
| if (!isServiceEnabled()) { | |||
| if (!isServiceEnabled(scopeId)) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lorthirk
force-pushed
the
change-dynamicConfigurationPropertiesScope
branch
from
45db115 to
32539dd
Compare
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
lorthirk
force-pushed
the
change-dynamicConfigurationPropertiesScope
branch
from
32539dd to
14c496a
Compare
Coduz
approved these changes
Jun 16, 2020
LeoNerdoG
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the
scopeIdparameter toisServiceEnabled()andisPropertyEnabled()methods signature, so that it can be used in the evaluationRelated Issue
No related issues