Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary dependencies of netty-all #3009

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 2, 2020

This PR removes unnecessary imports of netty-all dependency.

Each dependency will import its netty-* transient dependencies on their own.
This also cleans up the startup of the Docker Jetty containers.

Related Issue
None

Description of the solution adopted
Just removed dependencies of netty-all.
In kapua-broker-assembly they were left for simplicity

mvn dependency:tree
Before: netty-all.txt
After: netty-all-removed.txt

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #3009 into develop will decrease coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3009      +/-   ##
=============================================
- Coverage      57.58%   55.55%   -2.03%     
+ Complexity      2596     2587       -9     
=============================================
  Files           1062     1062              
  Lines          22988    22988              
  Branches        2043     2043              
=============================================
- Hits           13237    12771     -466     
- Misses          8804     9292     +488     
+ Partials         947      925      -22     
Impacted Files Coverage Δ Complexity Δ
...apua/broker/core/plugin/KapuaBrokerErrorCodes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...r/core/plugin/KapuaDuplicateClientIdException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...lator/app/deploy/DeploymentPackageInformation.java 0.00% <0.00%> (-93.75%) 0.00% <0.00%> (ø%)
...g/eclipse/kapua/kura/simulator/util/Documents.java 0.00% <0.00%> (-84.62%) 0.00% <0.00%> (ø%)
...kapua/kura/simulator/app/deploy/DownloadState.java 0.00% <0.00%> (-84.62%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/kura/simulator/payload/Message.java 0.00% <0.00%> (-84.22%) 0.00% <0.00%> (ø%)
...imulator/app/deploy/AbstractDeployApplication.java 2.27% <0.00%> (-69.32%) 0.00% <0.00%> (ø%)
...a/kura/simulator/app/deploy/BundleInformation.java 0.00% <0.00%> (-66.67%) 0.00% <0.00%> (ø%)
...a/service/account/internal/AccountCreatorImpl.java 48.57% <0.00%> (-51.43%) 0.00% <0.00%> (ø%)
.../org/eclipse/kapua/kura/simulator/app/Request.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
... and 34 more

@Coduz Coduz merged commit 834992c into eclipse:develop Jul 3, 2020
@Coduz Coduz deleted the fix-nettyAllReferences branch July 3, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants