Added Junit Tests for LocalCache Class #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3014 +/- ##
=============================================
+ Coverage 58.35% 58.46% +0.10%
Complexity 2601 2601
=============================================
Files 1070 1070
Lines 22863 22863
Branches 2023 2023
=============================================
+ Hits 13341 13366 +25
+ Misses 8591 8560 -31
- Partials 931 937 +6 |
Coduz
requested changes
Jul 24, 2020
| for (int expireAfter : expireAfterList) { | ||
| for (Object defaultValue : defaultValueList) { | ||
| LocalCache<Object, Object> localCache = new LocalCache<>(sizeMax, expireAfter, defaultValue); | ||
| assertNotNull(localCache); |
There was a problem hiding this comment.
| LocalCache<Object, Object> localCache = new LocalCache<>(sizeMax, expireAfter, defaultValue); | ||
| assertNotNull(localCache); | ||
| assertEquals("Expected and actual values should be the same.", defaultValue, localCache.get(defaultValueList)); | ||
| assertThat("LocalCache object expected.", localCache, IsInstanceOf.instanceOf(LocalCache.class)); |
There was a problem hiding this comment.
| for (int sizeMax : sizeMaxList) { | ||
| for (Object defaultValue : defaultValueList) { | ||
| LocalCache<Object, Object> localCache = new LocalCache<>(sizeMax, defaultValue); | ||
| assertNotNull("Null not expected.", localCache); |
There was a problem hiding this comment.
| LocalCache<Object, Object> localCache = new LocalCache<>(sizeMax, defaultValue); | ||
| assertNotNull("Null not expected.", localCache); | ||
| assertEquals("Expected and actual values should be the same.", defaultValue, localCache.get(defaultValueList)); | ||
| assertThat("LocalCache object expected.", localCache, IsInstanceOf.instanceOf(LocalCache.class)); |
There was a problem hiding this comment.
sonja-ct
force-pushed
the
localCache
branch
2 times, most recently
from
da8fd52 to
6971f43
Compare
|
Hey @Coduz, |
Coduz
approved these changes
Sep 2, 2020
Signed-off-by: Sonja <sonja.matic@comtrade.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Junit Tests for LocalCache Class
Signed-off-by: Sonja sonja.matic@comtrade.com
Related Issue
/
Description of the solution adopted
/
Screenshots
/
Any side note on the changes made
/