Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Path annotation in DeviceManagementOperations REST APIs #3040

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

lorthirk
Copy link

In #2795 {scopeId}/devices/{deviceId}/operations and {scopeId}/devices/{deviceId}/operations/{operationId}/notifications were inadvertently removed. This is to restore them.

Related Issue
No related issues

@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday labels Jul 29, 2020
@lorthirk lorthirk requested a review from Coduz July 29, 2020 14:59
@lorthirk lorthirk force-pushed the fix-mangementOperationRestApi branch from f3b9a80 to 5f3fad7 Compare July 29, 2020 14:59
@lorthirk lorthirk changed the title Restore @Path in DeviceManagementOperations REST APIs Restore Path annotation in DeviceManagementOperations REST APIs Jul 29, 2020
@lorthirk lorthirk force-pushed the fix-mangementOperationRestApi branch from 5f3fad7 to 25756a6 Compare July 29, 2020 15:00
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lorthirk,
please update the headers in the edited files.

@lorthirk lorthirk force-pushed the fix-mangementOperationRestApi branch from 25756a6 to f3e365a Compare July 30, 2020 06:06
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #3040 into develop will decrease coverage by 2.29%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3040      +/-   ##
=============================================
- Coverage      57.99%   55.69%   -2.30%     
- Complexity      2592     2657      +65     
=============================================
  Files           1062     1074      +12     
  Lines          23012    25155    +2143     
  Branches        2043     2511     +468     
=============================================
+ Hits           13346    14011     +665     
- Misses          8717    10141    +1424     
- Partials         949     1003      +54     
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/service/user/internal/UserQueryImpl.java 62.50% <0.00%> (-37.50%) 2.00% <0.00%> (ø%)
...n/internal/DeviceManagementOperationQueryImpl.java 62.50% <0.00%> (-37.50%) 2.00% <0.00%> (ø%)
...rnal/ManagementOperationNotificationQueryImpl.java 62.50% <0.00%> (-37.50%) 2.00% <0.00%> (ø%)
...lipse/kapua/service/tag/internal/TagQueryImpl.java 66.66% <0.00%> (-33.34%) 1.00% <0.00%> (ø%)
...rvice/endpoint/internal/EndpointInfoQueryImpl.java 66.66% <0.00%> (-33.34%) 1.00% <0.00%> (ø%)
...nternal/JobDeviceManagementOperationQueryImpl.java 66.66% <0.00%> (-33.34%) 1.00% <0.00%> (ø%)
...g/eclipse/kapua/kura/simulator/util/Documents.java 52.38% <0.00%> (-32.24%) 0.00% <0.00%> (ø%)
...pua/service/account/internal/AccountQueryImpl.java 71.42% <0.00%> (-28.58%) 0.00% <0.00%> (ø%)
...a/service/account/internal/AccountServiceImpl.java 56.46% <0.00%> (-28.43%) 0.00% <0.00%> (ø%)
.../org/eclipse/kapua/kura/simulator/topic/Topic.java 39.07% <0.00%> (-26.49%) 0.00% <0.00%> (ø%)
... and 91 more

@Coduz Coduz merged commit a7fb639 into eclipse:develop Aug 28, 2020
@lorthirk lorthirk deleted the fix-mangementOperationRestApi branch October 19, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants