Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sso doc grammatical errors #3045

Merged
merged 1 commit into from Aug 6, 2020
Merged

Fix sso doc grammatical errors #3045

merged 1 commit into from Aug 6, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2020

This PR fixes SSO doc grammatical errors.

Signed-off-by: Geetha Rangaswamaiah <geetha.r02@infosys.com>
@ghost ghost marked this pull request as ready for review August 3, 2020 09:52
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3045 into develop will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3045      +/-   ##
=============================================
- Coverage      57.99%   57.79%   -0.20%     
- Complexity      2592     2599       +7     
=============================================
  Files           1062     1062              
  Lines          23012    23012              
  Branches        2043     2043              
=============================================
- Hits           13346    13300      -46     
- Misses          8717     8757      +40     
- Partials         949      955       +6     
Impacted Files Coverage Δ Complexity Δ
...a/service/account/internal/AccountCreatorImpl.java 48.57% <0.00%> (-51.43%) 0.00% <0.00%> (ø%)
...a/service/account/internal/AccountServiceImpl.java 59.71% <0.00%> (-25.18%) 0.00% <0.00%> (ø%)
...ons/configuration/KapuaConfigurationException.java 37.50% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...stractKapuaConfigurableResourceLimitedService.java 76.19% <0.00%> (-9.53%) 0.00% <0.00%> (ø%)
...lugin/authentication/AdminAuthenticationLogic.java 69.23% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...pse/kapua/service/job/internal/JobServiceImpl.java 78.57% <0.00%> (-2.86%) 20.00% <0.00%> (ø%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 87.80% <0.00%> (-2.44%) 22.00% <0.00%> (-1.00%)
...onfiguration/AbstractKapuaConfigurableService.java 76.19% <0.00%> (-0.69%) 0.00% <0.00%> (ø%)
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 67.71% <0.00%> (+0.78%) 21.00% <0.00%> (+1.00%)
...nnection/internal/DeviceConnectionServiceImpl.java 69.66% <0.00%> (+2.24%) 17.00% <0.00%> (+1.00%)
... and 4 more

@Coduz Coduz added the Documentation Doc... What?? Joke! We will write some! label Aug 6, 2020
@Coduz Coduz merged commit 395d848 into eclipse:develop Aug 6, 2020
@Coduz
Copy link
Contributor

Coduz commented Aug 6, 2020

Hi @geetha-rangaswamaiah ,

This has been merged in develop and backported in release-1.2.x and released with Kapua 1.2.5.

Regards,

Alberto

@ghost ghost deleted the sso-doc branch August 6, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Doc... What?? Joke! We will write some!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant