Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kura-kapua docs grammatical errors #3050

Merged
merged 2 commits into from Aug 27, 2020
Merged

Fix kura-kapua docs grammatical errors #3050

merged 2 commits into from Aug 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2020

This PR fixes kura-kapua docs grammatical errors.

Signed-off-by: Geetha Rangaswamaiah <geetha.r02@infosys.com>
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3050 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3050      +/-   ##
=============================================
- Coverage      57.99%   57.83%   -0.16%     
- Complexity      2592     2595       +3     
=============================================
  Files           1062     1061       -1     
  Lines          23012    22874     -138     
  Branches        2043     2028      -15     
=============================================
- Hits           13346    13230     -116     
+ Misses          8717     8696      -21     
+ Partials         949      948       -1     
Impacted Files Coverage Δ Complexity Δ
...vice/device/registry/internal/DeviceQueryImpl.java 85.71% <0.00%> (-14.29%) 2.00% <0.00%> (ø%)
...e/kapua/service/user/internal/UserFactoryImpl.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (-1.00%)
...pua/broker/core/listener/ErrorMessageListener.java 70.83% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...lugin/authentication/AdminAuthenticationLogic.java 69.23% <0.00%> (-7.70%) 0.00% <0.00%> (ø%)
...a/org/eclipse/kapua/commons/model/id/KapuaEid.java 75.00% <0.00%> (-6.25%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/service/user/internal/UserImpl.java 71.05% <0.00%> (-5.27%) 16.00% <0.00%> (-1.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 70.44% <0.00%> (-4.32%) 0.00% <0.00%> (ø%)
...rvice/device/registry/common/DeviceValidation.java 71.25% <0.00%> (-2.50%) 14.00% <0.00%> (-1.00%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 87.80% <0.00%> (-2.44%) 22.00% <0.00%> (-1.00%)
...apua/model/query/predicate/AttributePredicate.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 10 more

@ghost ghost marked this pull request as ready for review August 13, 2020 05:57
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @geetha-rangaswamaiah,
I have checked your changes, and there are some fixes to be made. Please go through document one more time. Thanks!
I would also like to kindly ask you to pack all the syntax error fixes into one PR instead of creating tnes of PRs just for syntax errors...

docs/kuraKapuaDocs.md Outdated Show resolved Hide resolved
docs/kuraKapuaDocs.md Outdated Show resolved Hide resolved
docs/kuraKapuaDocs.md Outdated Show resolved Hide resolved
Signed-off-by: Geetha Rangaswamaiah <geetha.r02@infosys.com>
@Coduz Coduz added the Documentation Doc... What?? Joke! We will write some! label Aug 26, 2020
@LeoNerdoG
Copy link
Contributor

Hey @Coduz,
I have checekd this, it is OK, you can merge this.

@Coduz Coduz merged commit 88bb468 into eclipse:develop Aug 27, 2020
@Coduz
Copy link
Contributor

Coduz commented Aug 27, 2020

Hi @geetha-rangaswamaiah ,

This has been merged in develop and backported in release-1.2.x and released with Kapua 1.2.5.

Regards,

Alberto

@ghost ghost deleted the kura-kapua-docs branch August 27, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Doc... What?? Joke! We will write some!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants