Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker Security Plugin enhancements #3066

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

riccardomodanese
Copy link
Contributor

@riccardomodanese riccardomodanese commented Sep 9, 2020

Broker security plugin/context cleanup.
Reorganize the security context related objects and make the authorization code pluggable to allow extension.

Related Issue
none

Description of the solution adopted
none

Screenshots
none

Any side note on the changes made
none

@riccardomodanese riccardomodanese added the Enhancement This PR/Issue improves an part of Kapua label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #3066 into develop will increase coverage by 1.27%.
The diff coverage is 75.75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3066      +/-   ##
=============================================
+ Coverage      59.61%   60.88%   +1.27%     
- Complexity      2489     2588      +99     
=============================================
  Files           1071     1073       +2     
  Lines          22870    22922      +52     
  Branches        2023     2033      +10     
=============================================
+ Hits           13633    13956     +323     
+ Misses          8307     8017     -290     
- Partials         930      949      +19     
Impacted Files Coverage Δ Complexity Δ
...oker/core/message/system/SystemMessageCreator.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ua/broker/core/plugin/KapuaSecurityAclChecker.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../kapua/broker/core/plugin/metric/ClientMetric.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...pua/broker/core/plugin/metric/SecurityMetrics.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...r/core/plugin/authorization/DefaultAuthorizer.java 50.00% <50.00%> (ø) 0.00 <0.00> (?)
...kapua/broker/core/plugin/KapuaSecurityContext.java 69.31% <67.08%> (-1.52%) 0.00 <0.00> (ø)
...ore/plugin/authentication/AuthenticationLogic.java 85.00% <69.23%> (ø) 0.00 <0.00> (ø)
...lugin/authentication/AdminAuthenticationLogic.java 71.42% <75.00%> (+2.19%) 0.00 <0.00> (ø)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 74.85% <76.51%> (-1.01%) 0.00 <0.00> (ø)
...plugin/authentication/UserAuthenticationLogic.java 83.03% <80.35%> (+8.03%) 0.00 <0.00> (ø)
... and 56 more

@riccardomodanese riccardomodanese force-pushed the fix-securityPlugin_rebased branch 2 times, most recently from 6a11898 to 684820e Compare September 15, 2020 10:24
@riccardomodanese riccardomodanese force-pushed the fix-securityPlugin_rebased branch from 684820e to b89874b Compare September 23, 2020 16:31
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@riccardomodanese riccardomodanese force-pushed the fix-securityPlugin_rebased branch from b89874b to d99d294 Compare September 24, 2020 08:13
- change broker.port to broker.connector.internal.port on properties files

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@riccardomodanese riccardomodanese force-pushed the fix-securityPlugin_rebased branch from 8b9a8b7 to 23317be Compare September 24, 2020 16:11
@riccardomodanese riccardomodanese merged commit 9d2ba95 into develop Sep 24, 2020
@riccardomodanese riccardomodanese deleted the fix-securityPlugin_rebased branch September 24, 2020 16:14
@Coduz Coduz changed the title Fix security plugin rebased Broker Security Plugin enhancements Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants