Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Multi Factor Authentication #3137

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

lorthirk
Copy link

A bunch of fixes for the MFA feature introduced in #3125

Related Issue
No related issues

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! Enhancement This PR/Issue improves an part of Kapua Console GWT This issue/PR is related to Admin Web Console labels Nov 11, 2020
@lorthirk lorthirk requested a review from Coduz November 11, 2020 16:18
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3137 (f84e20d) into develop (95cc7d3) will decrease coverage by 8.72%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3137      +/-   ##
=============================================
- Coverage      62.94%   54.21%   -8.73%     
- Complexity      2479     3049     +570     
=============================================
  Files           1118     1118              
  Lines          23134    34732   +11598     
  Branches        1998     3776    +1778     
=============================================
+ Hits           14562    18831    +4269     
- Misses          7656    14796    +7140     
- Partials         916     1105     +189     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/eclipse/kapua/model/domain/Actions.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...java/org/eclipse/kapua/KapuaRuntimeErrorCodes.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...java/org/eclipse/kapua/MissingKapuaErrorCodes.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
.../org/eclipse/kapua/model/xml/BinaryXmlAdapter.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...rg/eclipse/kapua/message/xml/XmlAdaptedMetric.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...ipse/kapua/commons/model/id/KapuaEidConverter.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/locator/KapuaLocatorErrorCodes.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/model/xml/ObjectTypeXmlAdapter.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...pse/kapua/commons/util/KapuaCommonsErrorCodes.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...rg/eclipse/kapua/service/stream/StreamDomains.java 50.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
... and 1108 more

@Coduz Coduz merged commit 1382af3 into eclipse:develop Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants