Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA trigger end date changed to avoid TriggerNeverFiresException #3175

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

gbarbon
Copy link
Member

@gbarbon gbarbon commented Dec 15, 2020

This PR fixes an issue that produced a TriggerNeverFiresException in some Cucumber tests, making QAs fail. The cause was due to the hardcoded end date of the trigger in the Cucumber scenarios, which was set to a date prior to the current date.

Related Issue
n/a

Description of the solution adopted
The year in the start and end dates of some scenarios of the TriggerServiceI9n.feature has been changed to 2030.

Screenshots
n/a

Any side note on the changes made
This is only a fast fix, a better solution would be to dynamically generated dates in the Cucumber scenarios, instead of using hardcoded dates. A dedicated issue (see #3176 ) has been created to track such improvement.

Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #3175 (e22f8cf) into develop (9468dcc) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3175      +/-   ##
=============================================
- Coverage      63.06%   63.05%   -0.02%     
- Complexity      2487     2490       +3     
=============================================
  Files           1118     1118              
  Lines          23145    23145              
  Branches        2004     2004              
=============================================
- Hits           14596    14593       -3     
- Misses          7627     7629       +2     
- Partials         922      923       +1     
Impacted Files Coverage Δ Complexity Δ
...pua/broker/core/listener/ErrorMessageListener.java 70.83% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...lugin/authentication/AdminAuthenticationLogic.java 71.42% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 67.41% <0.00%> (-2.25%) 16.00% <0.00%> (-1.00%)
...plugin/authentication/UserAuthenticationLogic.java 81.25% <0.00%> (-1.79%) 0.00% <0.00%> (ø%)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 74.57% <0.00%> (-0.29%) 0.00% <0.00%> (ø%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.52% <0.00%> (+0.31%) 0.00% <0.00%> (ø%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 90.24% <0.00%> (+2.43%) 23.00% <0.00%> (+1.00%)
.../DeviceManagementOperationRegistryServiceImpl.java 69.64% <0.00%> (+3.57%) 14.00% <0.00%> (+2.00%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) 5.00% <0.00%> (+1.00%)

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Test Test related stuff. It's a dirty job, but someone needs to do that! labels Dec 16, 2020
@Coduz Coduz merged commit 9c6b814 into eclipse:develop Dec 16, 2020
@gbarbon gbarbon deleted the fix-qaFailureTriggerNeverFiresEx branch December 21, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants