Added index on DeviceConnection table #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coduz <alberto.codutti@eurotech.com>
riccardomodanese
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performances of the Device retrieval when DeviceConnection are to be fetched.
Related Issue
None
Description of the solution adopted
The JOIN performed was matching
device.connection_id = device_connection.id.On
dvc_device_connectionthere are only indexes that starts withscope_id.For some (forgotten) reasons
dvc_device_connectionhas the PK as(scope_id,id).All of this results in a full search on the DeviceConnection table which kills performances.
Adding this index, access changes from full search to using the index, which is very very fast.
Screenshots
None
Any side note on the changes made
None