Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indexes on jBatch tables to improve performances #3191

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jan 12, 2021

Looking at the access on jBatch SQL tables we found that some query where not using indexes, which could be a performance issue.

Related Issue
None

Description of the solution adopted
Checking the jBatch DAOs in job-engine-jbatch module, indexes have been created accordingly.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jan 12, 2021
@Coduz Coduz requested a review from lorthirk January 12, 2021 11:37
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #3191 (680e19c) into develop (dd481c5) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3191      +/-   ##
=============================================
+ Coverage      63.06%   63.11%   +0.05%     
- Complexity      2489     2494       +5     
=============================================
  Files           1118     1118              
  Lines          23146    23146              
  Branches        2004     2004              
=============================================
+ Hits           14597    14609      +12     
+ Misses          7627     7618       -9     
+ Partials         922      919       -3     
Impacted Files Coverage Δ Complexity Δ
...obDeviceManagementOperationManagerServiceImpl.java 76.82% <0.00%> (-2.44%) 14.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 67.41% <0.00%> (-2.25%) 16.00% <0.00%> (-1.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.21% <0.00%> (-0.32%) 0.00% <0.00%> (ø%)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 31.60% <0.00%> (+1.03%) 30.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 51.85% <0.00%> (+1.85%) 8.00% <0.00%> (ø%)
...ce/management/commons/call/DeviceCallExecutor.java 67.44% <0.00%> (+4.65%) 0.00% <0.00%> (ø%)
...ua/broker/core/listener/DeviceMessageListener.java 67.44% <0.00%> (+6.97%) 0.00% <0.00%> (ø%)
.../DeviceManagementOperationRegistryServiceImpl.java 73.21% <0.00%> (+7.14%) 16.00% <0.00%> (+4.00%)
...ob/engine/jbatch/exception/JobEngineException.java 66.66% <0.00%> (+33.33%) 2.00% <0.00%> (+1.00%)
.../engine/jbatch/exception/JobResumingException.java 50.00% <0.00%> (+50.00%) 1.00% <0.00%> (+1.00%)

@Coduz Coduz merged commit fa9aaa3 into eclipse:develop Jan 12, 2021
@Coduz Coduz deleted the fix-addIndexOnJobInstanceData branch February 5, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants