Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GenericRequestPayload translation #3282

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 19, 2021

This PR fixes a bug introduced with #3210, which is preventing GenericRequestPayload to be translated back.

Related Issue
None

Description of the solution adopted
Just added handling of GenericRequestPayload using factory.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Mar 19, 2021
@Coduz Coduz requested a review from lorthirk March 19, 2021 11:04
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #3282 (90a8e71) into develop (311d76e) will decrease coverage by 13.17%.
The diff coverage is 50.00%.

❗ Current head 90a8e71 differs from pull request most recent head bb1ba98. Consider uploading reports for the commit bb1ba98 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3282       +/-   ##
==============================================
- Coverage      53.85%   40.67%   -13.18%     
+ Complexity       785      682      -103     
==============================================
  Files           1467     1467               
  Lines          29943    29946        +3     
  Branches        2504     2505        +1     
==============================================
- Hits           16126    12182     -3944     
- Misses         12890    17136     +4246     
+ Partials         927      628      -299     
Impacted Files Coverage Δ Complexity Δ
...pua/AbstractSimpleTranslatorResponseKuraKapua.java 52.38% <50.00%> (-1.47%) 0.00 <0.00> (ø)
...pse/kapua/kura/simulator/GatewayConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...lipse/kapua/service/tag/internal/TagQueryImpl.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...a/kura/simulator/birth/BirthCertificateModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../job/engine/exception/JobMissingStepException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../kapua/service/tag/internal/TagListResultImpl.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...job/engine/exception/KapuaJobEngineErrorCodes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...pua/service/account/internal/AccountQueryImpl.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...engine/jbatch/driver/JbatchJobRunningStatuses.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ua/service/datastore/internal/schema/Metadata.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 212 more

Coduz added 2 commits March 22, 2021 16:28
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the fix-genericRequestPayloadTranslation branch from 90a8e71 to bb1ba98 Compare March 22, 2021 15:28
@Coduz Coduz merged commit 175c140 into eclipse:develop Mar 23, 2021
@Coduz Coduz deleted the fix-genericRequestPayloadTranslation branch July 6, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants