Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO - OIDC environment variables renaming #3298

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

gbarbon
Copy link
Member

@gbarbon gbarbon commented Apr 23, 2021

This PR renames the environment variables used for OIDC (OpenID Connect) by introducing the KAPUA_OPEID_ prefix.
Moreover, all the SSO OIDC documentation has been updated accordingly and improved (with a focus on environment variables).

Related Issue
Fix #3261

Description of the solution adopted
n/a

Screenshots
n/a

Any side note on the changes made
Please note that this is a breaking change , since the renaming of the environment variable names in an existing environment will prevent Kapua from loading the SSO provider configuration, if existing environment variables are not updated accordingly.

@gbarbon gbarbon added the Enhancement This PR/Issue improves an part of Kapua label Apr 23, 2021
@gbarbon gbarbon self-assigned this Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #3298 (e990e3a) into develop (5b1deb8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3298      +/-   ##
=============================================
- Coverage      55.03%   54.97%   -0.06%     
+ Complexity       787      786       -1     
=============================================
  Files           1478     1478              
  Lines          30235    30235              
  Branches        2523     2523              
=============================================
- Hits           16639    16622      -17     
- Misses         12682    12691       +9     
- Partials         914      922       +8     
Impacted Files Coverage Δ Complexity Δ
...pua/job/engine/exception/JobResumingException.java 0.00% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...kapua/job/engine/exception/JobEngineException.java 54.54% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
.../DeviceManagementOperationRegistryServiceImpl.java 66.07% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...ua/broker/core/listener/DeviceMessageListener.java 60.46% <0.00%> (-6.98%) 0.00% <0.00%> (ø%)
...ce/management/commons/call/DeviceCallExecutor.java 62.79% <0.00%> (-4.66%) 0.00% <0.00%> (ø%)
...e/registry/internal/DeviceRegistryServiceImpl.java 59.15% <0.00%> (-2.82%) 0.00% <0.00%> (ø%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 87.80% <0.00%> (-2.44%) 22.00% <0.00%> (-1.00%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 45.00% <0.00%> (-1.67%) 8.00% <0.00%> (ø%)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 30.56% <0.00%> (-1.04%) 30.00% <0.00%> (ø%)
...pse/kapua/commons/service/internal/ServiceDAO.java 75.23% <0.00%> (-0.95%) 0.00% <0.00%> (ø%)
... and 1 more

@gbarbon gbarbon requested review from lorthirk and Coduz April 23, 2021 12:41
@gbarbon gbarbon marked this pull request as ready for review April 23, 2021 12:41
gbarbon added 2 commits April 29, 2021 12:32
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
@gbarbon gbarbon force-pushed the feature-ssoOidcEnvVarRenaming branch from 1c44a91 to e990e3a Compare April 29, 2021 10:36
@gbarbon gbarbon requested review from Coduz and lorthirk April 29, 2021 10:38
@Coduz Coduz merged commit 64c17fd into eclipse:develop Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO: OIDC env variables names should be improved
3 participants