Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortDir and sortParam to REST APIs - Round 1 #3349

Merged
merged 6 commits into from
Jul 7, 2021

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Jul 7, 2021

Add the sortParam and sortDir params to the following REST APIs:

  • Accounts simple query
  • DeviceBundles simple query
  • Users simple query
  • Roles->Users simple query
  • Permissions (users and roles) simple query
  • DeviceEvents simple query

Related Issue
No related issue

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday labels Jul 7, 2021
@lorthirk lorthirk requested a review from Coduz July 7, 2021 09:47
@lorthirk lorthirk force-pushed the feature-restApiSortRound1 branch from 89e3909 to 2922d98 Compare July 7, 2021 10:50
Claudio Mezzasalma added 5 commits July 7, 2021 12:53
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the feature-restApiSortRound1 branch from 2922d98 to 839e630 Compare July 7, 2021 10:53
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #3349 (69be43e) into develop (dd0ec6e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 69be43e differs from pull request most recent head 839e630. Consider uploading reports for the commit 839e630 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3349      +/-   ##
=============================================
- Coverage      54.32%   54.28%   -0.05%     
+ Complexity       877      874       -3     
=============================================
  Files           1536     1536              
  Lines          30938    30956      +18     
  Branches        2564     2574      +10     
=============================================
- Hits           16807    16804       -3     
- Misses         13190    13211      +21     
  Partials         941      941              
Impacted Files Coverage Δ
.../api/resources/v1/resources/AccessPermissions.java 0.00% <0.00%> (ø)
...kapua/app/api/resources/v1/resources/Accounts.java 0.00% <0.00%> (ø)
...a/app/api/resources/v1/resources/DeviceEvents.java 0.00% <ø> (ø)
...esources/v1/resources/DeviceManagementBundles.java 0.00% <0.00%> (ø)
...se/kapua/app/api/resources/v1/resources/Roles.java 0.00% <0.00%> (ø)
...p/api/resources/v1/resources/RolesPermissions.java 0.00% <0.00%> (ø)
...se/kapua/app/api/resources/v1/resources/Users.java 0.00% <0.00%> (ø)
...obDeviceManagementOperationManagerServiceImpl.java 73.17% <0.00%> (-6.10%) ⬇️
...atch/persistence/jpa/JpaExecutionInstanceData.java 87.80% <0.00%> (-2.44%) ⬇️
...ua/broker/core/listener/DeviceMessageListener.java 67.44% <0.00%> (+6.97%) ⬆️

@lorthirk lorthirk merged commit 6f52797 into eclipse:develop Jul 7, 2021
@lorthirk lorthirk deleted the feature-restApiSortRound1 branch July 7, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants