Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hasMfa method #3531

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Conversation

MDeLuise
Copy link
Contributor

Brief description of the PR
It is possible to discover if an account MFA is enabled for a given account name by sending an unauthenticated POST request.
This PR fixes this problem, thus the security of the system is improved.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #3531 (9d6c76c) into develop (c1dbf0e) will decrease coverage by 21.80%.
The diff coverage is 11.53%.

❗ Current head 9d6c76c differs from pull request most recent head 3b4fe49. Consider uploading reports for the commit 3b4fe49 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3531       +/-   ##
==============================================
- Coverage      50.12%   28.31%   -21.81%     
+ Complexity       259       10      -249     
==============================================
  Files           1648     1648               
  Lines          31793    31772       -21     
  Branches        2642     2639        -3     
==============================================
- Hits           15935     8997     -6938     
- Misses         14925    22004     +7079     
+ Partials         933      771      -162     
Impacted Files Coverage Δ
.../app/api/core/resources/AbstractKapuaResource.java 0.00% <0.00%> (-100.00%) ⬇️
...sources/v1/resources/DeviceManagementPackages.java 0.00% <0.00%> (ø)
...cation/shiro/realm/UserPassCredentialsMatcher.java 29.16% <0.00%> (+11.66%) ⬆️
...ation/shiro/realm/UserPassAuthenticatingRealm.java 43.24% <16.66%> (-32.03%) ⬇️
...app/api/core/settings/KapuaApiCoreSettingKeys.java 100.00% <100.00%> (ø)
...rc/main/java/org/eclipse/kapua/KapuaException.java 0.00% <0.00%> (-100.00%) ⬇️
...c/main/java/org/eclipse/kapua/KapuaErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/org/eclipse/kapua/broker/BrokerDomain.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/eclipse/kapua/commons/util/ClassUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/org/eclipse/kapua/event/ServiceEvent.java 0.00% <0.00%> (-100.00%) ⬇️
... and 559 more

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Mar 18, 2022
@Coduz Coduz added the Console GWT This issue/PR is related to Admin Web Console label Mar 18, 2022
@Coduz Coduz merged commit e303ada into eclipse:develop Mar 18, 2022
@MDeLuise MDeLuise deleted the fix-hasMfaUnauthenticated branch February 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Console GWT This issue/PR is related to Admin Web Console Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

2 participants