Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proper error message when INVENTORY-V1/containers resource is requested but not supported #3573

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 7, 2022

This PR adds a more friendlier error message when INVENTORY-V1/GET/container is requested to a device which does not support it (early releases of INVENTORY-V1)

Related Issue
None

Description of the solution adopted
Added the handling of the specific error code that is returned by the device.

Screenshots
None

Any side note on the changes made
None

…equested but not supported

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jul 7, 2022
@Coduz Coduz added the Console GWT This issue/PR is related to Admin Web Console label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #3573 (a2a832d) into develop (f07cd53) will decrease coverage by 6.74%.
The diff coverage is n/a.

❗ Current head a2a832d differs from pull request most recent head eab37d6. Consider uploading reports for the commit eab37d6 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3573      +/-   ##
=============================================
- Coverage      33.54%   26.79%   -6.75%     
  Complexity       147      147              
=============================================
  Files           1662     1662              
  Lines          31940    31940              
  Branches        2643     2643              
=============================================
- Hits           10713     8558    -2155     
- Misses         20374    22607    +2233     
+ Partials         853      775      -78     
Impacted Files Coverage Δ
...lipse/kapua/service/tag/internal/TagQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...ns/configuration/KapuaConfigurationErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
...ns/liquibase/settings/LiquibaseClientSettings.java 0.00% <0.00%> (-100.00%) ⬇️
.../kapua/service/tag/internal/TagListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...liquibase/settings/LiquibaseClientSettingKeys.java 0.00% <0.00%> (-100.00%) ⬇️
...pua/service/account/internal/AccountQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...ervice/authorization/role/shiro/RoleQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...ervice/account/internal/AccountListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...vice/authorization/group/shiro/GroupQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...vice/authorization/role/shiro/RoleCreatorImpl.java 0.00% <0.00%> (-100.00%) ⬇️
... and 169 more

@Coduz Coduz merged commit 79c79e0 into eclipse:develop Jul 7, 2022
@Coduz Coduz deleted the chng-properErrorMessageInventoryContainerNotFound branch July 7, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Console GWT This issue/PR is related to Admin Web Console Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

1 participant