Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Docker Compose unquoted ports #3575

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 7, 2022

According to note documentation from Docker usage of unquoted ports is not recommended.

Docker Hub Docs

Documentation notes states:

When mapping ports in the HOST:CONTAINER format, you may experience erroneous results when using a container port lower than 60, because YAML parses numbers in the format xx:yy as a base-60 value. For this reason, we recommend always explicitly specifying your port mappings as strings.

Related Issue
None

Description of the solution adopted
Added quotes to ports definition is Docker Compose

Screenshots
None

Any side note on the changes made
None

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #3575 (880fee0) into develop (f07cd53) will decrease coverage by 7.86%.
The diff coverage is n/a.

❗ Current head 880fee0 differs from pull request most recent head 5fa1896. Consider uploading reports for the commit 5fa1896 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3575      +/-   ##
=============================================
- Coverage      33.54%   25.67%   -7.87%     
+ Complexity       147      115      -32     
=============================================
  Files           1662     1662              
  Lines          31940    31940              
  Branches        2643     2643              
=============================================
- Hits           10713     8200    -2513     
- Misses         20374    23389    +3015     
+ Partials         853      351     -502     
Impacted Files Coverage Δ
...se/kapua/commons/model/query/QueryFactoryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...pse/kapua/kura/simulator/GatewayConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
...lipse/kapua/service/job/internal/JobQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...lipse/kapua/service/tag/internal/TagQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...kapua/transport/mqtt/MqttResponseTimeoutTimer.java 0.00% <0.00%> (-100.00%) ⬇️
...ons/configuration/ServiceConfigListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...a/kura/simulator/birth/BirthCertificateModule.java 0.00% <0.00%> (-100.00%) ⬇️
.../kapua/service/job/internal/JobListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../kapua/service/tag/internal/TagListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...pse/kapua/service/device/call/kura/KuraMethod.java 0.00% <0.00%> (-100.00%) ⬇️
... and 757 more

@Coduz Coduz merged commit f764b9e into eclipse:develop Jul 7, 2022
@Coduz Coduz deleted the fix-unquotedDockerComposePorts branch July 7, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

2 participants