Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto utils tests #3582

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Crypto utils tests #3582

merged 2 commits into from
Jul 22, 2022

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jul 22, 2022

This PR adds test for CryptoUtil class.

The aim, other than the basic testing, is to ensure that components used to encrypt/decrypt will be compatible between releases and component version upgrades.

Related Issue
None

Description of the solution adopted
Added tests!

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #3582 (0926ea0) into develop (f25db7a) will decrease coverage by 3.66%.
The diff coverage is n/a.

❗ Current head 0926ea0 differs from pull request most recent head 3ef8bd9. Consider uploading reports for the commit 3ef8bd9 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3582      +/-   ##
=============================================
- Coverage      50.07%   46.40%   -3.67%     
+ Complexity       259      184      -75     
=============================================
  Files           1662     1662              
  Lines          31940    31940              
  Branches        2643     2643              
=============================================
- Hits           15994    14822    -1172     
- Misses         15010    16278    +1268     
+ Partials         936      840      -96     
Impacted Files Coverage Δ
...a/org/eclipse/kapua/commons/crypto/CryptoUtil.java 76.19% <ø> (+31.74%) ⬆️
...del/query/predicate/ChannelMatchPredicateImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...ent/packages/message/internal/PackageResource.java 0.00% <0.00%> (-100.00%) ⬇️
...kages/model/internal/DevicePackageOptionsImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...l/setting/PackageManagementServiceSettingKeys.java 0.00% <0.00%> (-100.00%) ⬇️
...oad/internal/DevicePackageDownloadOptionsImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...lator/app/deploy/DeploymentPackageInformation.java 0.00% <0.00%> (-93.75%) ⬇️
...internal/DeviceManagementOperationCreatorImpl.java 0.00% <0.00%> (-92.86%) ⬇️
...g/eclipse/kapua/kura/simulator/util/Documents.java 0.00% <0.00%> (-88.24%) ⬇️
...ura/kapua/TranslatorAppConfigurationKuraKapua.java 4.22% <0.00%> (-87.33%) ⬇️
... and 94 more

Coduz added 2 commits July 22, 2022 13:33
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-cryptoUtilsTests branch from 9fa1b69 to 3ef8bd9 Compare July 22, 2022 11:33
@Coduz Coduz merged commit 670050c into eclipse:develop Jul 22, 2022
@Coduz Coduz deleted the feature-cryptoUtilsTests branch July 25, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
Development

Successfully merging this pull request may close these issues.

1 participant