Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of deeply nested attributes inside KapuaEntities #3665

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

Agnul97
Copy link
Contributor

@Agnul97 Agnul97 commented Dec 6, 2022

This PR extends a method inside ServiceDAO class that handles the extraction of deeply nested attributes inside kapuaEntities. Specifically, the method was limited to nested attributes up to 2 levels and this was a limitation for the querying of some attributes inside a particular table

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3665 (b3fed5f) into develop (7d7bd49) will decrease coverage by 16.25%.
The diff coverage is 100.00%.

❗ Current head b3fed5f differs from pull request most recent head d416427. Consider uploading reports for the commit d416427 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3665       +/-   ##
==============================================
- Coverage      50.24%   33.98%   -16.26%     
+ Complexity       259      120      -139     
==============================================
  Files           1686     1686               
  Lines          32173    32179        +6     
  Branches        2643     2645        +2     
==============================================
- Hits           16164    10937     -5227     
- Misses         15066    20705     +5639     
+ Partials         943      537      -406     
Impacted Files Coverage Δ
...pse/kapua/commons/service/internal/ServiceDAO.java 63.60% <100.00%> (-4.31%) ⬇️
...kapua/transport/mqtt/MqttResponseTimeoutTimer.java 0.00% <0.00%> (-100.00%) ⬇️
.../kapua/service/tag/internal/TagListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...pse/kapua/service/device/call/kura/KuraMethod.java 0.00% <0.00%> (-100.00%) ⬇️
...rt/mqtt/pooling/setting/MqttClientPoolSetting.java 0.00% <0.00%> (-100.00%) ⬇️
...ua/service/datastore/internal/schema/Metadata.java 0.00% <0.00%> (-100.00%) ⬇️
.../service/datastore/internal/model/DataIndexBy.java 0.00% <0.00%> (-100.00%) ⬇️
...qtt/pooling/setting/MqttClientPoolSettingKeys.java 0.00% <0.00%> (-100.00%) ⬇️
...rvice/endpoint/internal/EndpointInfoQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...vice/datastore/internal/DatastoreCacheManager.java 0.00% <0.00%> (-100.00%) ⬇️
... and 298 more

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Dec 13, 2022
@Coduz Coduz changed the title Correct handling of deeply nested attributes inside kapuaEntities Correct handling of deeply nested attributes inside KapuaEntities Dec 13, 2022
@Coduz Coduz merged commit 468b05c into eclipse:develop Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
Development

Successfully merging this pull request may close these issues.

2 participants