Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling and checking of values in Birth Message #3697

Merged
merged 15 commits into from
Feb 2, 2023

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jan 17, 2023

This PR improves the handling of fields of the Birth Message which create/update the information of a device.

Main improvements are:

Related Issue
This PR fixes #1237 and fixes #2726

Description of the solution adopted

  • Added validation for all DeviceCreator/Device fields.
  • for connectionIp and connectionInterfaces an "overflow" field has been created to handle big values.

Screenshots
None

Any side note on the changes made
A bit of code cleanup and javadoc cleanup

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Jan 17, 2023
@Coduz Coduz requested a review from stefanomorson January 17, 2023 17:26
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #3697 (feec075) into develop (395caa2) will decrease coverage by 14.72%.
The diff coverage is 63.26%.

❗ Current head feec075 differs from pull request most recent head 383a8b0. Consider uploading reports for the commit 383a8b0 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3697       +/-   ##
============================================
- Coverage    41.75%   27.03%   -14.72%     
============================================
  Files         1822     1822               
  Lines        33791    33948      +157     
  Branches      2663     2715       +52     
============================================
- Hits         14109     9178     -4931     
- Misses       18699    24044     +5345     
+ Partials       983      726      -257     
Impacted Files Coverage Δ
.../engine/commons/operation/DefaultTargetReader.java 0.00% <0.00%> (ø)
.../engine/commons/operation/DefaultTargetWriter.java 0.00% <0.00%> (ø)
...ob/engine/commons/wrappers/StepContextWrapper.java 0.00% <0.00%> (ø)
...a/service/device/registry/DeviceServiceModule.java 0.00% <0.00%> (ø)
...e/device/registry/KapuaDeviceRegistrySettings.java 100.00% <ø> (+100.00%) ⬆️
.../registry/internal/DeviceExtendedPropertyImpl.java 6.45% <ø> (ø)
...a/service/device/registry/internal/DeviceImpl.java 59.11% <37.50%> (-8.91%) ⬇️
...rvice/device/registry/common/DeviceValidation.java 74.87% <72.43%> (-12.82%) ⬇️
...evice/registry/KapuaDeviceRegistrySettingKeys.java 100.00% <100.00%> (+100.00%) ⬆️
...eclipse/kapua/KapuaOptimisticLockingException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 490 more

@Coduz Coduz force-pushed the feature-truncateBirthFields branch 2 times, most recently from 4156b5b to 88d73ca Compare January 18, 2023 14:20
@Coduz Coduz marked this pull request as ready for review January 18, 2023 18:00
@Coduz Coduz force-pushed the feature-truncateBirthFields branch 8 times, most recently from 6c30fe8 to 298cabc Compare January 26, 2023 10:46
@Coduz Coduz force-pushed the feature-truncateBirthFields branch 2 times, most recently from 8e2a6b4 to c43d1c3 Compare January 30, 2023 14:33
Coduz added 10 commits January 31, 2023 10:40
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…le big values from connectied Device

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
… SettingKeys

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…e.length.max' setting

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz added 2 commits January 31, 2023 10:40
…ations

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-truncateBirthFields branch from c43d1c3 to 5b0646b Compare January 31, 2023 09:42
Coduz added 2 commits January 31, 2023 16:46
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…moved not being backward compatible

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-truncateBirthFields branch from 75c0b50 to 51c8d6e Compare January 31, 2023 16:10
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
2 participants