-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling and checking of values in Birth Message #3697
Merged
Coduz
merged 15 commits into
eclipse-kapua:develop
from
Coduz:feature-truncateBirthFields
Feb 2, 2023
Merged
Improve handling and checking of values in Birth Message #3697
Coduz
merged 15 commits into
eclipse-kapua:develop
from
Coduz:feature-truncateBirthFields
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3697 +/- ##
============================================
- Coverage 41.75% 27.03% -14.72%
============================================
Files 1822 1822
Lines 33791 33948 +157
Branches 2663 2715 +52
============================================
- Hits 14109 9178 -4931
- Misses 18699 24044 +5345
+ Partials 983 726 -257
|
Coduz
force-pushed
the
feature-truncateBirthFields
branch
2 times, most recently
from
January 18, 2023 14:20
4156b5b
to
88d73ca
Compare
Coduz
force-pushed
the
feature-truncateBirthFields
branch
8 times, most recently
from
January 26, 2023 10:46
6c30fe8
to
298cabc
Compare
Coduz
force-pushed
the
feature-truncateBirthFields
branch
2 times, most recently
from
January 30, 2023 14:33
8e2a6b4
to
c43d1c3
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…le big values from connectied Device Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
… SettingKeys Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…e.length.max' setting Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…ations Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-truncateBirthFields
branch
from
January 31, 2023 09:42
c43d1c3
to
5b0646b
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
…moved not being backward compatible Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-truncateBirthFields
branch
from
January 31, 2023 16:10
75c0b50
to
51c8d6e
Compare
.../src/main/java/org/eclipse/kapua/service/device/registry/KapuaDeviceRegistrySettingKeys.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of fields of the Birth Message which create/update the information of a device.
Main improvements are:
connectionInterface
device registry - device lifecycle test scenario may fail for some network configurations #1237connectionIp
Device registration error when connectionIp exceeds field size #2726Related Issue
This PR fixes #1237 and fixes #2726
Description of the solution adopted
DeviceCreator
/Device
fields.connectionIp
andconnectionInterfaces
an "overflow" field has been created to handle big values.Screenshots
None
Any side note on the changes made
A bit of code cleanup and javadoc cleanup