Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job execution log reports target name and target short uuid #3699

Merged
merged 15 commits into from
Jan 30, 2023

Conversation

MDeLuise
Copy link
Contributor

@MDeLuise MDeLuise commented Jan 18, 2023

Brief description of the PR
This PR fixes #3698, i.e. adds the target name and the target short uuid in the job execution log.
Before the fix the log was something like:

[INFO] 3/13/20 3:12 PM - Running before job...
[INFO] 3/13/20 3:12 PM - Run configuration:
[INFO] 3/13/20 3:12 PM - 	Target count:           1
[INFO] 3/13/20 3:12 PM - 	Reset step index:       false
[INFO] 3/13/20 3:12 PM - 	From step index:        0
[INFO] 3/13/20 3:12 PM - 	Resuming job execution: none
[INFO] 3/13/20 3:12 PM - 	Enqueue:                true
[INFO] 3/13/20 3:12 PM - Creating job execution...
[INFO] 3/13/20 3:12 PM - Creating job execution... DONE!
[INFO] 3/13/20 3:12 PM - Running before job... DONE!
[INFO] 3/13/20 3:12 PM - Opening cursor...
[INFO] 3/13/20 3:12 PM - Opening cursor... DONE!
[INFO] 3/13/20 3:12 PM - Reading item...
[INFO] 3/13/20 3:12 PM - Reading item... DONE!
[INFO] 3/13/20 3:12 PM - Processing item: 5437581105811942270
[INFO] 3/13/20 3:12 PM - Processing item: 5437581105811942270 - DONE!
[INFO] 3/13/20 3:12 PM - Reading item...
[INFO] 3/13/20 3:12 PM - Reading item... DONE!
[INFO] 3/13/20 3:12 PM - Writing items...
[INFO] 3/13/20 3:12 PM - Writing items... DONE!
[INFO] 3/13/20 3:12 PM - Opening cursor...
[INFO] 3/13/20 3:12 PM - Opening cursor... DONE!
[INFO] 3/13/20 3:12 PM - Reading item...
[INFO] 3/13/20 3:12 PM - Reading item... DONE!
[INFO] 3/13/20 3:12 PM - Processing item: 5437581105811942270
[INFO] 3/13/20 3:12 PM - Processing item: 5437581105811942270 - DONE!
[INFO] 3/13/20 3:12 PM - Reading item...
[INFO] 3/13/20 3:12 PM - Reading item... DONE!
[INFO] 3/13/20 3:12 PM - Writing items...
[INFO] 3/13/20 3:12 PM - Writing items... DONE!
[INFO] 3/13/20 3:12 PM - Running after job...

After the fix the log is something like:

[INFO] 1/18/23, 9:52 AM - Running before job...
[INFO] 1/18/23, 9:52 AM - Run configuration:
[INFO] 1/18/23, 9:52 AM - 	Target count:           all
[INFO] 1/18/23, 9:52 AM - 	Reset step index:       false
[INFO] 1/18/23, 9:52 AM - 	From step index:        0
[INFO] 1/18/23, 9:52 AM - 	Resuming job execution: none
[INFO] 1/18/23, 9:52 AM - 	Enqueue:                true
[INFO] 1/18/23, 9:52 AM - Creating job execution...
[INFO] 1/18/23, 9:52 AM - Creating job execution... DONE!
[INFO] 1/18/23, 9:52 AM - Running before job... DONE!
[INFO] 1/18/23, 9:52 AM - Opening cursor...
[INFO] 1/18/23, 9:52 AM - Opening cursor... DONE!
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)...
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)... DONE!
[INFO] 1/18/23, 9:52 AM - Processing target:pahoClient (id:UzxkKAd0L70)
[ERROR] 1/18/23, 9:52 AM - Processing target:pahoClient (id:UzxkKAd0L70) - Error! The device 7100943599675787352 is not CONNECTED. Current device connection status is: DISCONNECTED
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)...
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)... DONE!
[INFO] 1/18/23, 9:52 AM - Writing items...
[INFO] 1/18/23, 9:52 AM - Writing items... DONE!
[INFO] 1/18/23, 9:52 AM - Opening cursor...
[INFO] 1/18/23, 9:52 AM - Opening cursor... DONE!
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)...
[INFO] 1/18/23, 9:52 AM - Reading target:pahoClient (id:UzxkKAd0L70)... DONE!
[INFO] 1/18/23, 9:52 AM - Running after job...

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #3699 (38fa90f) into develop (9cdcf8a) will decrease coverage by 16.95%.
The diff coverage is 0.00%.

❗ Current head 38fa90f differs from pull request most recent head 7b97865. Consider uploading reports for the commit 7b97865 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3699       +/-   ##
==============================================
- Coverage      55.46%   38.52%   -16.95%     
==============================================
  Files           1821     1822        +1     
  Lines          33787    33791        +4     
  Branches        2661     2663        +2     
==============================================
- Hits           18740    13018     -5722     
- Misses         14056    19786     +5730     
+ Partials         991      987        -4     
Impacted Files Coverage Δ
...mmons/operation/AbstractDeviceTargetProcessor.java 0.00% <0.00%> (ø)
...ine/commons/operation/AbstractTargetProcessor.java 0.00% <0.00%> (ø)
.../engine/commons/operation/DefaultTargetReader.java 0.00% <0.00%> (ø)
...ent/asset/job/DeviceAssetWriteTargetProcessor.java 0.00% <0.00%> (ø)
...t/bundle/job/DeviceBundleStartTargetProcessor.java 0.00% <0.00%> (ø)
...nt/bundle/job/DeviceBundleStopTargetProcessor.java 0.00% <0.00%> (ø)
.../command/job/DeviceCommandExecTargetProcessor.java 0.00% <0.00%> (ø)
...ion/job/DeviceConfigurationPutTargetProcessor.java 0.00% <0.00%> (ø)
...eviceKeystoreCertificateCreateTargetProcessor.java 0.00% <0.00%> (ø)
...e/job/DeviceKeystoreItemDeleteTargetProcessor.java 0.00% <0.00%> (ø)
... and 552 more

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jan 23, 2023
@Coduz Coduz merged commit 1e7fd4c into eclipse:develop Jan 30, 2023
@Coduz Coduz removed the Enhancement This PR/Issue improves an part of Kapua label Jan 30, 2023
@MDeLuise MDeLuise deleted the fix/better-job-log branch January 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job execution log should report target name and target short uuid
2 participants