Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - deletion of mandatory property for "displayName" device parameter #3741

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

Agnul97
Copy link
Contributor

@Agnul97 Agnul97 commented Mar 14, 2023

Deletes mandatory property for the property. Also, fixed a little typo on one duplicated dependency, which was causing warning on building

@Agnul97 Agnul97 marked this pull request as ready for review March 14, 2023 15:22
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3741 (c7864a1) into develop (94c3ac5) will decrease coverage by 12.96%.
The diff coverage is n/a.

❗ Current head c7864a1 differs from pull request most recent head bed727d. Consider uploading reports for the commit bed727d to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3741       +/-   ##
==============================================
- Coverage      55.85%   42.89%   -12.96%     
  Complexity         8        8               
==============================================
  Files           1835     1835               
  Lines          34138    34138               
  Branches        2726     2726               
==============================================
- Hits           19067    14645     -4422     
- Misses         14078    18749     +4671     
+ Partials         993      744      -249     

see 389 files with indirect coverage changes

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Mar 15, 2023
@Coduz Coduz merged commit 20a3fe9 into eclipse:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
Development

Successfully merging this pull request may close these issues.

2 participants