fix(deviceManagement): fixed validation of DeviceManagementBundle id validation #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
riccardomodanese
approved these changes
Dec 22, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3927 +/- ##
=============================================
- Coverage 20.64% 20.63% -0.01%
Complexity 6 6
=============================================
Files 1947 1947
Lines 41684 41691 +7
Branches 3954 3954
=============================================
Hits 8604 8604
- Misses 32681 32688 +7
Partials 399 399
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the documentation on the DeviceInventoryBundle.id attribute.
Related Issue
None
Description of the solution adopted
Improved documentation on REST API side and added a validation of the value provided to improve error returned to the user in case a non-number is provided.
Screenshots
None
Any side note on the changes made
None