fix(console): fixed error reporting for DeviceAssetChannel #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
added
Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3947 +/- ##
==========================================
Coverage 20.73% 20.73%
Complexity 6 6
==========================================
Files 1951 1951
Lines 41767 41767
Branches 3959 3959
==========================================
Hits 8661 8661
Misses 32703 32703
Partials 403 403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes showing of error messages when reading DeviceAssetChannels.
Previously there was no error shown and only successfully read channel were shown in the form
Related Issue
None
Description of the solution adopted
Added mapping in Console GWT of error property and displayed dedicated field in case of error
Screenshots
None
Any side note on the changes made
None