FIX - Problem of wrong serialization of ComposedKey fields on the cache #4032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug regarding our use of ComposedKey classes and the serialization of some of their fields in the context of the Caching mechanism. One of its fields (scopeId) is of type KapuaId. The problem is that sometimes we create ComposedKeys using a ScopeId instance and then we try to perform a lookup of the same cache entry but using a KapuaEid. If this doesn’t seem a problem from an object-oriented perspective, considering that they have the same internal Id and the equals method would return true, it is from a “serialization” for the cache perspective, because the serialization of the 2 fields is different and, as so, the lookup cannot behave as want.
I fixed the issue in the constructor of the ComposedKey class casting the various KapuaId passed in input to be a fixed KapuaEid