Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix: Credential Marshalling #4053

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

dseurotech
Copy link
Contributor

xml annotations on CredentialImpl were overriding the ones on Credential, preventing XmlJavaTypeAdapters from being calle
d

…redential, preventing XmlJavaTypeAdapters from being called

Signed-off-by: dseurotech <davide.salvador@eurotech.com>
@dseurotech dseurotech marked this pull request as ready for review June 7, 2024 10:19
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.78%. Comparing base (839d04d) to head (2fbb818).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4053      +/-   ##
=============================================
- Coverage      16.78%   16.78%   -0.01%     
  Complexity        22       22              
=============================================
  Files           2006     2006              
  Lines          52087    52089       +2     
  Branches        4383     4384       +1     
=============================================
  Hits            8745     8745              
- Misses         42947    42949       +2     
  Partials         395      395              
Files Coverage Δ
...entication/credential/mfa/shiro/MfaOptionImpl.java 100.00% <ø> (ø)
...tication/credential/mfa/shiro/ScratchCodeImpl.java 100.00% <ø> (ø)
...uthentication/credential/shiro/CredentialImpl.java 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Jun 7, 2024
@Coduz Coduz merged commit 901f997 into eclipse:develop Jun 7, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
Development

Successfully merging this pull request may close these issues.

2 participants