Fix add input validation to KapuaConfigurableServiceBase
#4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4069 +/- ##
=============================================
- Coverage 16.81% 16.80% -0.01%
Complexity 22 22
=============================================
Files 2008 2008
Lines 52164 52182 +18
Branches 4398 4398
=============================================
Hits 8770 8770
- Misses 42998 43016 +18
Partials 396 396
|
Coduz
requested changes
Jul 1, 2024
commons/src/main/java/org/eclipse/kapua/commons/configuration/KapuaConfigurableServiceBase.java
Outdated
Show resolved
Hide resolved
MDeLuise
force-pushed
the
fix-validateKapuaConfigurableServiceBase
branch
from
39e6353 to
e9cb74f
Compare
Added validation for scopeId and configValues in KapuaConfigurableServiceBase to prevent NullPointerExceptions. Ensured configValues is checked for null and emptiness.
MDeLuise
force-pushed
the
fix-validateKapuaConfigurableServiceBase
branch
from
e9cb74f to
62635ce
Compare
Coduz
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue in the
KapuaConfigurableServiceBasewhere input data was not being validated. The lack of validation could causeNullPointerExceptions(NPEs) forscopeIdandconfigValues.Changes Made
scopeIdis not null.configValuesis not null or empty.