Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use check-push-rights from kuksa-actions #680

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Oct 3, 2023

Use check-push and dco check from kuksa-common

Fixes #628
Fixes #677

uses https://github.com/erikbosch/kuksa-actions/blob/main/.github/workflows/check_push_rights.yml for testing

@erikbosch erikbosch force-pushed the erik-check_push branch 5 times, most recently from da4f8f2 to a95863d Compare October 3, 2023 12:47
@@ -31,7 +31,7 @@ concurrency:

jobs:
checkrights:
uses: ./.github/workflows/check_push_rights.yml
uses: erikbosch/kuksa-actions/.github/workflows/check_push_rights.yml@main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix for testing purposes having it in erikbosch, should later be eclipse-kuksa.

We should possibly also rename workflow to be more precise, like check_kuksa_ghcr_push_rights

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lets merge before it becomes complicated rebasing this

@SebastianSchildt SebastianSchildt merged commit 16aef83 into eclipse:master Oct 6, 2023
18 checks passed
@erikbosch erikbosch deleted the erik-check_push branch February 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash check runs in the "wrong place" in CI for Rust builds Handling of check push rights
2 participants