Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 203] Fix race condition in removeContext test #207

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

andymc12
Copy link
Contributor

@andymc12 andymc12 commented Jul 3, 2019

This change recycles the thread used for the asynchronous work (after the rest client work is done) and verifies that the thread locals set by the async rest client flow have been cleared.

This should go into 1.3.X-service and master.

This should resolve issue #203.

Signed-off-by: Andy McCright j.andrew.mccright@gmail.com

Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
@andymc12 andymc12 self-assigned this Jul 3, 2019
@andymc12
Copy link
Contributor Author

andymc12 commented Jul 3, 2019

@stuartwdouglas @reta - could you test to verify that this fixes the issue(s) you are seeing? I've run this several times locally (with Liberty that uses CXF) and it passes, but I never saw it fail before these changes.

@kenfinnigan
Copy link
Contributor

@cescoffier @asoldano @ronsigal any comments?

@reta
Copy link

reta commented Jul 3, 2019

@andymc12 thanks a lot for the fix, I will give it a try shortly

@asoldano
Copy link
Contributor

asoldano commented Jul 4, 2019

@kenfinnigan , I haven't reproduced the issue, but the changes look ok.

@reta
Copy link

reta commented Jul 5, 2019

@andymc12 I was playing with the TCK today (against CXF MP client). While the current implementation of the AsyncMethodTest::testAsyncInvocationInterceptorProvider was failing often, after applying the patch (this PR) I have not seen any failures anymore. Thanks again!

@andymc12 andymc12 merged commit c169925 into eclipse:1.3.X-service Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants