Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup of OpenSSL/LibreSSL CMake #1504

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fpagliughi
Copy link
Contributor

@fpagliughi fpagliughi commented Jul 20, 2024

This implements the fix for the SSL CMake issue I commented on in #1451, here

@marcfir

@fpagliughi fpagliughi requested a review from icraggs July 20, 2024 04:18
@fpagliughi
Copy link
Contributor Author

fpagliughi commented Jul 20, 2024

This also changes the CMake output to look a little more consistent (nicer, in my opinion):

-- CMake system name: Linux
-- Timestamp is 2024-07-20T04:11:46Z
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.2")  
-- Using OpenSSL with headers at /usr/include, lib /usr/lib/x86_64-linux-gnu/libssl.so
-- Configuring done

@fpagliughi
Copy link
Contributor Author

fpagliughi commented Jul 20, 2024

I also just pushed a 2nd commit into the PR.

Using CMAKE_SOURCE_DIR is not correct to find files relative to the project's source tree. It is the top-level directory in the build, and thus will change if the project is bring built from a subdirectory, such as using a Git submodule. (Thus it will be the directory of the parent project, not the Paho C project directory).

Using PROJECT_SOURCE_DIR will keep it pinned to the Paho C sources even if built as a subdirectory. (Using CMAKE_CURRENT_SOURCE_DIR would have worked here as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant