Protect PUT and POST endpoints of the BugController #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST and PUT calls of the BugController shall be protected through a dedicated, configurable token.
This token has to be added as HTTP header by all Java clients (kb-importer, patch-analyzer, patch-lib-analyzer) and by the bug frontend (frontend-bugs). The Java clients just require a corresponding configuration parameter (
vulas.shared.backend.header.<key>) in order to include the HTTP header.The HAProxy configuration has to be adjusted to check the configurable token for all HTTP PUT and POST requests to
.../backend/bugs/....TODOs