Skip to content

Commit

Permalink
Fix node version for dev container and add it to the readme
Browse files Browse the repository at this point in the history
* Align node versions to 14 as the build no longer works with node 12
* Add dev container to readme
  • Loading branch information
lucas-koehler authored and sdirix committed May 25, 2022
1 parent 6928b38 commit a3d2ac0
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.191.1/containers/javascript-node/.devcontainer/base.Dockerfile

# [Choice] Node.js version: 16, 14, 12
ARG VARIANT="16-buster"
# [Choice] Node.js version: 16, 14
ARG VARIANT="14"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

# [Optional] Uncomment this section to install additional OS packages.
Expand Down
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"name": "Node.js",
"build": {
"dockerfile": "Dockerfile",
// Update 'VARIANT' to pick a Node version: 12, 14, 16
// Update 'VARIANT' to pick a Node version: 14, 16
"args": {
"VARIANT": "12"

This comment has been minimized.

Copy link
@Soumennnn

Soumennnn Jul 5, 2022

12????

"VARIANT": "14"
}
},
// Set *default* container specific settings.json values on container create.
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ In addition, EclipseSource also offers [professional support](https://jsonforms.
* Install dependencies: `npm ci`
* Hook up dependencies between packages: `npm run init`

### VS Code dev container

As an alternative to the first time setup, you can use the provided [VS Code dev container](https://code.visualstudio.com/docs/remote/containers) configured in [devcontainer.json](.devcontainer/devcontainer.json).

* Execute command: `Remote Containers: Reopen in container`
* Wait until the container is built and loaded
* First time setup and an initial build of all packages has been executed in the container

### Build & Testing

* Build (all packages): `npm run build`
Expand Down

0 comments on commit a3d2ac0

Please sign in to comment.