[ionic] Address review comments

eclipsesource · Jan 24, 2019 · db68697 · db68697
1 parent 4f2d6be
commit db68697
Show file tree

Hide file tree

Showing 11 changed files with 713 additions and 661 deletions.
diff --git a/packages/angular/src/control.ts b/packages/angular/src/control.ts
@@ -87,6 +87,8 @@ export class JsonFormsControl extends JsonFormsBaseRenderer<ControlElement>
         this.enabled ? this.form.enable() : this.form.disable();
         this.hidden = !visible;
         this.scopedSchema = Resolve.schema(schema, uischema.scope);
+        this.description =
+          this.scopedSchema !== undefined ? this.scopedSchema.description : '';
         this.id = props.id;
         this.form.setValue(data);
         this.mapAdditionalProps(props);

diff --git a/packages/ionic/package.json b/packages/ionic/package.json
@@ -56,6 +56,7 @@
     "@ionic-native/status-bar": "4.7.0",
     "@jsonforms/angular": "^2.1.1-alpha.2",
     "@jsonforms/core": "^2.1.1-alpha.2",
+    "angular-l10n": "^4.0.0-rc.0",
     "ionic-angular": "3.9.2",
     "ionic-selectable": "^3.0.3",
     "ionicons": "3.0.0",