Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Renderer is used as the fall back renderer for controls #1103

Closed
eneufeld opened this issue Oct 4, 2018 · 0 comments
Closed

Text Renderer is used as the fall back renderer for controls #1103

eneufeld opened this issue Oct 4, 2018 · 0 comments
Assignees
@eneufeld
Milestone
2.1.0

Comments

@eneufeld
Copy link
Member

eneufeld commented Oct 4, 2018

Describe the bug
If you define a uischema with a control, then the fallback for all control renderers is the text renderer. This is not always the best solution and we should discuss whether it would be better to simply show the unknownRenderer instead.
@edgarmueller edgarmueller added this to the 2.1.0 milestone Nov 19, 2018
eneufeld added a commit to eneufeld/jsonforms that referenced this issue Dec 3, 2018
@eneufeld
String control is not used as fallback for controls anymore
50ab9b2 
* Pins the tests in angular based renderers to isStringControl
* Cleanups the manual field dispatch in MaterialInputControl

Fixes eclipsesource#1103
@eneufeld eneufeld mentioned this issue Dec 3, 2018
Merged
@eneufeld eneufeld self-assigned this Dec 3, 2018
eneufeld added a commit to eneufeld/jsonforms that referenced this issue Dec 19, 2018
@eneufeld
String control is not used as fallback for controls anymore
8054689 
* Pins the tests in angular based renderers to isStringControl
* Cleanups the manual field dispatch in MaterialInputControl

Fixes eclipsesource#1103
edgarmueller pushed a commit that referenced this issue Dec 20, 2018
@eneufeld @edgarmueller
String control is not used as fallback for controls anymore
de04b64 
* Pins the tests in angular based renderers to isStringControl
* Cleanups the manual field dispatch in MaterialInputControl

Fixes #1103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eneufeld eneufeld

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@edgarmueller @eneufeld