-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation not working with multiple forms #1329
Comments
Thanks for the report! You are right, it seems we broke the example, thanks for noticing. The problem is that the validator configuration is wrong as we don't call the store.dispatch(
Actions.init(
{},
{
type: "object",
properties: {
person: schemas.person,
shippingAddress: schemas.address
}
}
)
); But this isn't very nice, so we'll need to address this in one of the upcoming releases. |
@edgarmueller I am about to use this library to create a multiple forms project and I would like to know if there is an approximate date to the release of the 2.3.0 version. I assume that this version will fully support the multiple forms including errors, schemas and validators in a single store. |
@DavidHenri008 Thanks for the kind words! We started working on this issue, and it seems likely that we'll support a Context-based API which currently seems to be the cleanest solution for this problem as each |
Add context-based mapping functions to react package. Disconnect React based renderer sets and provide redux based context via JsonFormsReduxContext. Dispatch component has been renamed to JsonFormsDispatch, while the updated JsonForms component can now be used standalone and provides isolation, i.e. redux is not mandatory anymore. Fixes eclipsesource#1329.
Add context-based mapping functions to react package. Disconnect React based renderer sets and provide redux based context via JsonFormsReduxContext. Dispatch component has been renamed to JsonFormsDispatch, while the updated JsonForms component can now be used standalone and provides isolation, i.e. redux is not mandatory anymore. Fixes eclipsesource#1329.
Add context-based mapping functions to react package. Disconnect React based renderer sets and provide redux based context via JsonFormsReduxContext. Dispatch component has been renamed to JsonFormsDispatch, while the updated JsonForms component can now be used standalone and provides isolation, i.e. redux is not mandatory anymore. Fixes eclipsesource#1329.
Add context-based mapping functions to react package. Disconnect React based renderer sets and provide redux based context via JsonFormsReduxContext. Dispatch component has been renamed to JsonFormsDispatch, while the updated JsonForms component can now be used standalone and provides isolation, i.e. redux is not mandatory anymore. Fixes eclipsesource#1329.
Add context-based mapping functions to react package. Disconnect React based renderer sets and provide redux based context via JsonFormsReduxContext. Dispatch component has been renamed to JsonFormsDispatch, while the updated JsonForms component can now be used standalone and provides isolation, i.e. redux is not mandatory anymore. Fixes eclipsesource#1329.
Describe the bug
The multiple forms example in https://jsonforms.io/docs/store has 'required' validation that does not seem to work.
I also get the same issue when attempting to use multiple forms in a single store on my react project.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When input is required, I expected to see red required text.
Screenshots
Validation not working
Validation Working
Browser (please complete the following information):
The text was updated successfully, but these errors were encountered: