Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TSLint with ESLint and Prettier #1551

Closed
sdirix opened this issue Feb 26, 2020 · 2 comments
Closed

Replace TSLint with ESLint and Prettier #1551

sdirix opened this issue Feb 26, 2020 · 2 comments
Assignees
@lucas-koehler
Labels
dev
Milestone
3.1

Comments

@sdirix
Copy link
Member

sdirix commented Feb 26, 2020

TSLint is officially deprecated. Move to ESLint + Prettier: https://prettier.io/docs/en/integrating-with-linters.html
This was referenced Feb 27, 2020
Merged
Merged
@sdirix sdirix added this to the next milestone Nov 21, 2020
@sdirix sdirix modified the milestones: next, 3.x May 12, 2021
@sdirix sdirix modified the milestones: 3.x, 3.1 Nov 10, 2022
@sdirix sdirix self-assigned this Nov 10, 2022
@lucas-koehler
Copy link
Contributor

lucas-koehler commented Feb 27, 2023 •
edited
Loading

  • Integrate Prettier in ESLint so that prettier formatting is applied on linting.
  • For prettier:
    • use single quotes
    • use line ending auto to be compatible with Windows development using default Git settings.
  • Prefer rule recommendations over explicitly configuring many.
  • Consider making the packages' configs self-contained in each package as long as there is not too much duplication

Prettier doc on integration with linters: https://prettier.io/docs/en/integrating-with-linters.html

@lucas-koehler lucas-koehler changed the title Remove TSLint Replace TSLint with ESLint and Prettier Mar 8, 2023
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Mar 10, 2023
@lucas-koehler
Replace TSLint with ESLint and Prettier
1ef6ad6 
- Remove TSLint dependencies and config
- Add ESLint and Prettier dependencies and config for all packages
  except the Angular ones

Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Mar 10, 2023
@lucas-koehler
angular: Configure ESLint and Prettier
53f2ba1 
- Add ESLint and Prettier config for Angular packages
- Revert back to ESLint 7.x from 8.x because the Angular eslint plugin
  for Angular 12 does not work with ESLint 8.x

Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Mar 10, 2023
@lucas-koehler
Update package-lock.json for ESLint and Prettier
55b44dc 
Part of eclipsesource#1551
@lucas-koehler lucas-koehler mentioned this issue Mar 10, 2023
Merged
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 14, 2023
@lucas-koehler
Replace TSLint with ESLint and Prettier configuration
47b95fe 
- Remove TSLint dependencies and config
- Add ESLint and Prettier dependencies and config for all packages
- Add markdownlint to recommended extensions
- Use ESLint 7.x instead of 8.x because the Angular eslint plugin
  for Angular 12 does not work with ESLint 8.x

Disabled rules for to be re-enabled later:
- explicit any warnings
- no-prototype-builtins rule
- import/no-named-as-default for 2 packages
  - vanilla-renderers
  - material-renderers

Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Apply ESLint auto fixes
7b6f73c 
Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Format remaining files with prettier
e1622da 
Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Fix ESLint issues
67d3a38 
Fix remaining ESLint issues with these exceptions that will be handled in a follow up
- import/no-named-as-default in vanilla-renderers, material-renderers
- no-prototype-builtins
- @typescript-eslint/no-explicit-any
- typescript-eslint/ban-types

Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Execute ESLint on CI for Ubuntu builds
32b8ec2 
Part of eclipsesource#1551
@lucas-koehler lucas-koehler mentioned this issue Apr 21, 2023
Open
5 tasks
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Fix ESLint issues
0ceac94 
Fix remaining ESLint issues with these exceptions that will be handled in a follow up
- import/no-named-as-default in vanilla-renderers, material-renderers
- no-prototype-builtins
- @typescript-eslint/no-explicit-any
- typescript-eslint/ban-types

Part of eclipsesource#1551
lucas-koehler added a commit to lucas-koehler/jsonforms that referenced this issue Apr 21, 2023
@lucas-koehler
Execute ESLint on CI for Ubuntu builds
d447946 
Part of eclipsesource#1551
sdirix pushed a commit that referenced this issue Apr 21, 2023
@lucas-koehler @sdirix
Replace TSLint with ESLint and Prettier configuration
39b4dc6 
- Remove TSLint dependencies and config
- Add ESLint and Prettier dependencies and config for all packages
- Add markdownlint to recommended extensions
- Use ESLint 7.x instead of 8.x because the Angular eslint plugin
  for Angular 12 does not work with ESLint 8.x

Disabled rules for to be re-enabled later:
- explicit any warnings
- no-prototype-builtins rule
- import/no-named-as-default for 2 packages
  - vanilla-renderers
  - material-renderers

Part of #1551
sdirix pushed a commit that referenced this issue Apr 21, 2023
@lucas-koehler @sdirix
Apply ESLint auto fixes
9350211 
Part of #1551
sdirix pushed a commit that referenced this issue Apr 21, 2023
@lucas-koehler @sdirix
Format remaining files with prettier
1f124e8 
Part of #1551
sdirix pushed a commit that referenced this issue Apr 21, 2023
@lucas-koehler @sdirix
Fix ESLint issues
437feda 
Fix remaining ESLint issues with these exceptions that will be handled in a follow up
- import/no-named-as-default in vanilla-renderers, material-renderers
- no-prototype-builtins
- @typescript-eslint/no-explicit-any
- typescript-eslint/ban-types

Part of #1551
sdirix pushed a commit that referenced this issue Apr 21, 2023
@lucas-koehler @sdirix
Execute ESLint on CI for Ubuntu builds
8c82d78 
Part of #1551
@lucas-koehler
Copy link
Contributor

Fixed via #2112 . Follow up tasks tracked in #2131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-koehler lucas-koehler

Labels
dev
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@lucas-koehler @sdirix