Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned labels on single select dropdown #2198

Closed
sgober opened this issue Oct 25, 2023 · 3 comments
Closed

Orphaned labels on single select dropdown #2198

sgober opened this issue Oct 25, 2023 · 3 comments

Comments

@sgober
Copy link
Contributor

sgober commented Oct 25, 2023

Describe the bug

When testing for 508 compliance, I noticed that the single select dropdown renderers have orphaned labels. The htmlFor on the label is for example "#/properties/92-input" but the id on the input is "#/properties/92", thus the label is orphaned and it shows up that the input has no label.

Expected behavior

Label should be correctly associated with the single select dropdown.

Steps to reproduce the issue

I use the wave chrome extension to see what 508 compliance errors there are, so all you need to do is have a single select in your schema and you can see that the label and input are not associated

Screenshots

Wave output example (red is missing input label error and orange is orphaned label warning):
Screenshot 2023-10-25 at 10 45 49 AM

Output example where for and id don't match:
Screenshot 2023-10-25 at 10 45 24 AM

In which browser are you experiencing the issue?

Google Chrome 118.0.5993.117

Which Version of JSON Forms are you using?

v3.0.0

Framework

React

RendererSet

Material

Additional context

No response

@sdirix
Copy link
Member

sdirix commented Oct 26, 2023

Hi @sgober,

Thanks for the report! Would you like to contribute a fix?

@sgober
Copy link
Contributor Author

sgober commented Oct 26, 2023

PR here: #2199

@sdirix sdirix removed this from the 3.x milestone Mar 27, 2024
@sdirix
Copy link
Member

sdirix commented Mar 27, 2024

Was fixed with 3.2

@sdirix sdirix closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants