Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Orphaned labels on single select dropdown #2199

Merged
merged 1 commit into from
Nov 13, 2023
Merged

BUGFIX: Orphaned labels on single select dropdown #2199

merged 1 commit into from
Nov 13, 2023

Conversation

sgober
Copy link
Contributor

@sgober sgober commented Oct 26, 2023

Removed "-input" from id on input so that the label and input are associated correctly. Will fix issue #2198

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 922f2cf
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/653a75312145ac0008838a24
😎 Deploy Preview https://deploy-preview-2199--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sgober sgober changed the title remove "-input" from id on input BUGFIX: Orphaned labels on single select dropdown Oct 26, 2023
@sgober sgober mentioned this pull request Oct 26, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 84.469%. remained the same when pulling 922f2cf on sgober:patch-1 into f905c82 on eclipsesource:master.

@sdirix
Copy link
Member

sdirix commented Oct 27, 2023

Thanks for the contribution ❤️ We will take a look soon

sdirix
sdirix approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as intended. Thanks for the contribution ❤️

@sdirix sdirix merged commit 6a739a6 into eclipsesource:master Nov 13, 2023
8 checks passed
@sdirix sdirix added this to the 3.2 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
bug material react
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sgober @CLAassistant @coveralls @sdirix