Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue to 3.4+ #2234

Closed
lucas-koehler opened this issue Jan 3, 2024 · 0 comments · Fixed by #2318
Closed

Update vue to 3.4+ #2234

lucas-koehler opened this issue Jan 3, 2024 · 0 comments · Fixed by #2318
Assignees
Labels
Milestone

Comments

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Jan 3, 2024

Is your feature request related to a problem? Please describe.

Updating the pnpm lock file to use vue 3.4.3 causes vue-vanilla's tests to fail with error:

Compiling...

  [=========================] 98% (after emitting)

 ERROR  Failed to compile with 1 error

This dependency was not found:

* node:stream in /home/user/jsonforms/node_modules/.pnpm/@vue+server-renderer@3.4.3_vue@3.4.3/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js

To install it, you can run: npm install --save node:stream
  [=========================] 100% (completed)

 WEBPACK  Failed to compile with 1 error(s)

Error in /home/user/jsonforms/node_modules/.pnpm/@vue+server-renderer@3.4.3_vue@3.4.3/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js

  Module not found: 'node:stream' in '/home/user/jsonforms/node_modules/.pnpm/@vue+server-renderer@3.4.3_vue@3.4.3/node_modules/@vue/server-renderer/dist'

 ERROR  mochapack exited with code 1.
 ELIFECYCLE  Test failed. See above for more details.

Using Node 18 instead of 16 did not solve the problem.

Describe the solution you'd like

Upgrade vue peer dependency to 3.4.3+ and fix the vue-vanilla package tests and/or other dependencies to still work.

Describe alternatives you've considered

Do not update vue. This is not a viable long-term solution

Framework

Vue 3

RendererSet

Vue Vanilla

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant