Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Use latest vue 3.4.21 & upgrade further dependencies #2318

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Apr 9, 2024

Fixes #2234

Use latest vue version 3.4.21 and recreate pnpm lock

  • Remove pnpm overrides for vue version to use latest version 3.4.21. Do not touch the peer dependency because no new vue code was introduced => it remains at ^3.2.26
  • Update vue cli dependencies to latest version ^5.0.8
  • Updater @vue.compiler-sfc and @vue/test-utils dependencies to latest versions
  • Fix vue vanilla test utils to attach mounted components to document. This is (now) necessary so that click events on checkbox inputs correctly trigger a change event.
  • Regenerate pnpm-lock file. This updates all dependencies to the latest version permitted by their version ranges.

Upgrade karma and ava to get rid of critical vulnerabilities in deps

Upgrade various dependencies to get rid of critical vulnerabilities in dependencies as reported by pnpm audit:

  • Remove obsolete ava and source-map-support root dev dependencies
  • Upgrade ava dependencies to ^6.1.2 and adapt tests and config accordingly
  • Replace source-map-support with later fork @cspotcode/source-map-support
  • Completely remove obsolete source-map-support dep from vanilla-renderers
  • Upgrade karma dependencies to ^6.4.1 and karma-webpack to ^5.0.0

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 146f683
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66156589ba37fd000850a862
😎 Deploy Preview https://deploy-preview-2318--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 9, 2024

Coverage Status

coverage: 84.396% (-0.4%) from 84.804%
when pulling 146f683 on issues/2234-vue-dep-upgrade
into c74b8ba on master.

@lucas-koehler lucas-koehler changed the title deps: Use latest vue version 3.4.21 and recreate pnpm lock deps: Use latest vue 3.4.21 upgrade further dependencies Apr 9, 2024
@lucas-koehler lucas-koehler added the dependencies Pull requests that update a dependency file label Apr 9, 2024
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added two questions

packages/angular/package.json Outdated Show resolved Hide resolved
packages/vue-vanilla/package.json Show resolved Hide resolved
@lucas-koehler lucas-koehler changed the title deps: Use latest vue 3.4.21 upgrade further dependencies deps: Use latest vue 3.4.21 & upgrade further dependencies Apr 9, 2024
- Remove pnpm overrides for vue version to use latest version 3.4.21.
  Do not touch the peer dependency because no new vue code was introduced.
- Update vue cli dependencies to latest version ^5.0.8
- Update @vue/test-utils dependencies to latest versions
- Remove obsolete explicit dependency to @vue/compiler-sfc
- Fix vue vanilla test utils to attach mounted components to document.
  This is (now) necessary so that click events on checkbox inputs correctly
  trigger a change event.
- Regenerate pnpm-lock file. This updates all dependencies to the latest version permitted by their version ranges.
Upgrade various dependencies to get rid of critical vulnerabilities in dependencies as reported by `pnpm audit`:

- Remove obsolete ava and source-map-support root dev dependencies
- Upgrade ava dependencies to ^6.1.2 and adapt tests and config accordingly
- Completely remove obsolete source-map-support dep from vanilla-renderers
- Upgrade karma dependencies to ^6.4.1 and karma-webpack to ^5.0.0
@sdirix sdirix merged commit d3801e9 into master Apr 11, 2024
11 checks passed
@sdirix sdirix deleted the issues/2234-vue-dep-upgrade branch April 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vue to 3.4+
3 participants