Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-vanilla - postfix of id of select element should be '-input' not '-select' #2363

Closed
changjung-kim opened this issue Jul 25, 2024 · 5 comments

Comments

@changjung-kim
Copy link
Contributor

changjung-kim commented Jul 25, 2024

Describe the bug

postfix of id of label id for enum type is set to '-select' though the label's for is expecting the postfix '-input' due to
the code

.

Expected behavior

postfix of id of select element should be '-input'.

Steps to reproduce the issue

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

No response

Which Version of JSON Forms are you using?

v3.3.0

Framework

Vue

RendererSet

Vanilla

Additional context

No response

@sdirix
Copy link
Member

sdirix commented Aug 7, 2024

@changjung-kim Thanks for the report! Would you like to contribute the fix?

@sdirix sdirix added this to the 3.4 milestone Aug 7, 2024
@changjung-kim
Copy link
Contributor Author

Okay. Sure.

@sdirix
Copy link
Member

sdirix commented Aug 20, 2024

Hi @changjung-kim I see you developed a fix. Would you like to open a PR?

@changjung-kim
Copy link
Contributor Author

changjung-kim commented Aug 20, 2024

Hi @sdirix Yes. I did. Please review and merge the PR. 😃

@sdirix
Copy link
Member

sdirix commented Aug 21, 2024

Fixed with #2368

@sdirix sdirix closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants